New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snapcraft recipe #2413
Add snapcraft recipe #2413
Conversation
Sorry for the late response. This is not invasive and we already have lots of (stale...) makefiles in the build folder so I don't see a reason against this here. @lotharsm Could you also provide a snapfile for the stable version? Then I could cherry-pick this into the stable-branch - just for reference, as I don't plan another stable release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on this so far! 👍
However, as I am an oldschool guy, the download and extracted sizes bug me a bit.
The snap content is almost 800M and download size 163M. We can save a bit bandwith and disk space (some pointers in the detailed review).
Thanks @carstene1ns for the suggestions! The download size for the snap itself is now 127M, the total installed size with all dependencies (this includes the environment brought in by snapd itself) is now at 527M. I'll try to bring it down further, but I think we are pretty close to the limit here. |
Okay, the download size is now down to 91M with an installed size of 248M. This is it, I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I know this is not necessary, but anyway: jenkins: test this please. |
Last weekend, I added the EasyRPG Player to the Snap Store (https://snapcraft.io/easyrpg-player) in order to make current EasyRPG Player easily available on Ubuntu and other Linux distributions.
For reference, this is the recipe used to build the snap package.
I'm planning to keep this package up-to-date in the future (since I really like the EasyRPG player) and backport all changes into this repository.
However, if you prefer to publish this under your own name/organisation, please ping me and I'll arrange a transfer of the Snap ownership (yes, it's a bit unfortunate that the Snap Store calls me "Developer" rather than "Publisher").