Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapcraft recipe #2413

Merged
merged 7 commits into from
Jan 17, 2021
Merged

Add snapcraft recipe #2413

merged 7 commits into from
Jan 17, 2021

Conversation

lotharsm
Copy link
Contributor

Last weekend, I added the EasyRPG Player to the Snap Store (https://snapcraft.io/easyrpg-player) in order to make current EasyRPG Player easily available on Ubuntu and other Linux distributions.

For reference, this is the recipe used to build the snap package.

I'm planning to keep this package up-to-date in the future (since I really like the EasyRPG player) and backport all changes into this repository.

However, if you prefer to publish this under your own name/organisation, please ping me and I'll arrange a transfer of the Snap ownership (yes, it's a bit unfortunate that the Snap Store calls me "Developer" rather than "Publisher").

@fdelapena fdelapena added this to the 0.6.3 milestone Nov 7, 2020
@Ghabry
Copy link
Member

Ghabry commented Nov 8, 2020

Sorry for the late response.
Thanks for the PR. Personally I'm not interested in maintaining a Snap repository, so I'm fine with a 3rd-party maintaining this (we already provide packages through OBS, though they are a bit outdated because our maintainer for this not around anymore)

This is not invasive and we already have lots of (stale...) makefiles in the build folder so I don't see a reason against this here.

@lotharsm Could you also provide a snapfile for the stable version? Then I could cherry-pick this into the stable-branch - just for reference, as I don't plan another stable release.

Copy link
Member

@carstene1ns carstene1ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this so far! 👍

However, as I am an oldschool guy, the download and extracted sizes bug me a bit.
The snap content is almost 800M and download size 163M. We can save a bit bandwith and disk space (some pointers in the detailed review).

builds/snap/snapcraft.yaml Outdated Show resolved Hide resolved
builds/snap/snapcraft.yaml Outdated Show resolved Hide resolved
builds/snap/snapcraft.yaml Outdated Show resolved Hide resolved
builds/snap/snapcraft.yaml Show resolved Hide resolved
builds/snap/snapcraft.yaml Outdated Show resolved Hide resolved
builds/snap/snapcraft.yaml Outdated Show resolved Hide resolved
@lotharsm
Copy link
Contributor Author

Thanks @carstene1ns for the suggestions!

The download size for the snap itself is now 127M, the total installed size with all dependencies (this includes the environment brought in by snapd itself) is now at 527M.

I'll try to bring it down further, but I think we are pretty close to the limit here.

@lotharsm
Copy link
Contributor Author

Okay, the download size is now down to 91M with an installed size of 248M. This is it, I think.

Copy link
Member

@carstene1ns carstene1ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@carstene1ns
Copy link
Member

I know this is not necessary, but anyway:

jenkins: test this please.

@carstene1ns carstene1ns merged commit c19b9ba into EasyRPG:master Jan 17, 2021
@lotharsm lotharsm deleted the add-snapcraft-recipe branch January 17, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants