Fix and improve encoding detection #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Additional to title_name and system_name the cursor_se and the title_music are checked. - title_name and title_music are skipped when their is no title screen This is good enough for detecting the proper encoding of .flow (English translation). Fix EasyRPG#2554 Fix EasyRPG#2604
fdelapena
approved these changes
Sep 11, 2021
carstene1ns
approved these changes
Sep 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is good enough for detecting the proper encoding of .flow (English translation).
Fix #2554
Fix #2604
needs EasyRPG/liblcf#435