DirectMenuPatch #3192
Open
DirectMenuPatch #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdelapena
approved these changes
Mar 3, 2024
Ghabry
reviewed
Mar 4, 2024
Ghabry
reviewed
Mar 11, 2024
|
I will redo the API of these scenes to take an array of actors instead. Your solution works but lets improve it while we are at it (these scenes are around 10 years old, everything a bit dated ^^) |
fdelapena
added
the
Awaiting Rebase
…instance of Game_Actor Scenes that can handle multiple actors expect now an vector of actors. Makes it more flexible.
Ghabry
removed
the
Awaiting Rebase
|
Rebased and updated the API... About your extension to the Open Menu event command: I think this should get "ValueOrVariable" support so you can do indirection through it. (otherwise it has less functionality than the patch). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for the DirectMenuPatch for RM2k(3) as described in Makerpendiums patch database:
https://dev.makerpendium.de/docs/patch_db/main-en.htm?page=direct_menu
This patch is enabled by adding the following line to the [Patch] section in EasyRPG.ini
DirectMenu=[VariableId]Additionally the "OpenMainMenu" command is extended to mirror the same functionality. (If both variants are used, scenes set via command parameter take priority)
1st param: scene id
2nd param: party member id or actor id
3rd param: 0: party member id is used, 1: db actor id is used
Default var ids for this patch are V3326 & V3327
EDIT: It should be noted that in this implementation scene id 4 (Status) also works for RM2K and not just 2k3 engine type games.