Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommandTeleport (10810) - Allow com.string as map filename #3208

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jetrotal
Copy link
Contributor

image

You can teleport to a custom-named map, by filling com.string:

@raw 10810, "./Map/test", 0,0,0,3

It Even considers custom folder structure.

It still lacks some changes to support:

  • .po files from translations
  • Manipulate save data.

I have to learn how to implement those.

You can teleport to a custom-named map, by filling `com.string`.
It Even considers custom folder structure.
@Ghabry
Copy link
Member

Ghabry commented Apr 12, 2024

This is a bit more complex than just this command:

  • There is an event to save/recall locations
  • There is an event to store escape targets and teleport targets

They must be all updated to support this (+ save data).

Look for ReserveTeleport to find invocations:

https://github.com/search?q=repo%3AEasyRPG%2FPlayer%20ReserveTeleport&type=code


Carbonara: Using 0 here would make sense since the data cannot properly be stored as a value, what would be needed here is a "store map ID in a string variable" command

Ghabry: And there is also an event to relocate vehicles which takes a map_id >.> btw Events also have a map ID but I cannot remember what the purpose of this was.

@jetrotal
Copy link
Contributor Author

This is a bit more complex than just this command:

I put the filename logic inside of ConstructMapName, since multiple functions related to teleport went through it...
That was what made the command work 🤔

@jetrotal
Copy link
Contributor Author

ok, about stringVars: It's good to support it for feature completion.
I guess none of the teleport commands uses com.string. So, just filling this argument may be enough.

Converting ID entries to 0 if com.string exists seems fair too.

@Ghabry Ghabry marked this pull request as draft April 17, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants