New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game browser #664

Merged
merged 17 commits into from Dec 7, 2015

Conversation

Projects
None yet
3 participants
@Ghabry
Member

Ghabry commented Dec 6, 2015

Fixes #53 , almost 3 years old

Don't merge yet, there are still some issues I want to resolve.

This also renamed ProjectTree to DirectoryTree (because it's general purpose) and changes how the dummy bitmaps are rendered. In case of missing system it uses now an embedded System.png (from our TestGame).

Not in this release:
Navigation, it always uses the startup/working directory for searching games (but better then before ;)).
Is really only suited for systems without a simple way to browse, this is no replacment for the awesome Android Ui (yet?).

Bugs I won't fix:
Won't work with emscripten (too difficult to implement, use a game browser in the browser directly)
Windows can't load directories that are not in the current codepage (Reader issue, hard to fix). Can be worked around by renaming the folder. Imo Desktop systems should get a nicer Browser with GTK/Qt.

screenshot_0
screenshot_1

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Dec 6, 2015

Member

screenshot_0

Almost ready, just need to fix emscripten ;)

Member

Ghabry commented Dec 6, 2015

screenshot_0

Almost ready, just need to fix emscripten ;)

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Dec 6, 2015

Member

Hahaha great Ghabry !
But i have to let you know that my skill in Android are wayyy better than before, you shall definitvely not pass on the Android UI when I'll come back in April ;)

Member

BlisterB commented Dec 6, 2015

Hahaha great Ghabry !
But i have to let you know that my skill in Android are wayyy better than before, you shall definitvely not pass on the Android UI when I'll come back in April ;)

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Dec 6, 2015

Member

@blisterboy Great, looking forward to your new skills

Should be okay now.

I already updated the php file on the server, bad error handling bug...

Member

Ghabry commented Dec 6, 2015

@blisterboy Great, looking forward to your new skills

Should be okay now.

I already updated the php file on the server, bad error handling bug...

@fdelapena fdelapena added this to the 0.4 milestone Dec 6, 2015

@BlisterB

This comment has been minimized.

Show comment
Hide comment
@BlisterB

BlisterB Dec 7, 2015

Member

We will have to migrate the android port to Android Studio, graddle will permit to use some library such as the Support Library which will be usefull for the Android Gamebrowser (and will permit to clean code and have just one version of the GameBrowser class for all api).
I don't have the time to read what you've done but I assume you did some usefull function in C++ to detect wheter a directory is game folder or not etc. Some of them will maybe be usefull using JNI in the android port.

Member

BlisterB commented Dec 7, 2015

We will have to migrate the android port to Android Studio, graddle will permit to use some library such as the Support Library which will be usefull for the Android Gamebrowser (and will permit to clean code and have just one version of the GameBrowser class for all api).
I don't have the time to read what you've done but I assume you did some usefull function in C++ to detect wheter a directory is game folder or not etc. Some of them will maybe be usefull using JNI in the android port.

fdelapena added a commit that referenced this pull request Dec 7, 2015

@fdelapena fdelapena merged commit b57ee18 into EasyRPG:master Dec 7, 2015

6 checks passed

Android Build finished. No test results found.
Details
Linux Build finished. No test results found.
Details
Linux (static) Build finished. No test results found.
Details
OSX Build finished. No test results found.
Details
Windows Build finished. No test results found.
Details
web Build finished. No test results found.
Details

@Ghabry Ghabry deleted the Ghabry:game_browser branch Feb 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment