Make HardLight, Saturation, Fill and FileFinder faster #855

Ghabry · 2016-04-02T12:50:10Z

See the commit messages for detailed info.

I also measured hard light with and without lookup table. The lookup is cache unfriendly (64kb) but is faster then direct calculation because Hard light has a 50% branch prediction miss chance per color...

For saturation would be more tricky because RGB are combined here, I "only" saved an alloc and a blit here.

Fill (AddBackground, called once per frame) is also faster now by using OP_SRC which doesn't handle alpha correctly but that doesn't matter in this case.

Branch Pred: https://stackoverflow.com/questions/11227809/why-is-processing-a-sorted-array-faster-than-an-unsorted-array

Fixes #846

Hard Light uses now a lookup table and the code is almost branch free. The table hurts the cache because of it's size but is faster then without cache because hard light requires branching. Saturation saves now one allocation and one OVER blit.

…EAR Blit.

Ghabry · 2016-04-02T13:08:08Z

Speed tests on my old Android system (TestGame Tone map):
Tone: 42 FPS
Sat: 49 FPS
Both: 33 FPS

This PR:
Tone: 60 FPS
Sat: 59-60 FPS
Both: 58 FPS

BlisterB · 2016-04-02T13:23:07Z

Nice! People are very interested in the engine optimization since the official RPG Maker update, this surely is a good step forward!

Zegeri · 2016-04-02T15:23:02Z

src/bitmap.cpp

@@ -876,6 +891,22 @@ void Bitmap::ClearRect(Rect const& dst_rect) {
 	RefreshCallback();
 }

+// Hard light lookup table mapping source color to destination color
+static int hard_light_lookup[256][256];


Could this be using uint8_t for less memory footprint?

Ugh, very good find.

…while parsing.

Ghabry · 2016-04-02T20:55:15Z

Sorry I also added a non-blit operation to the speedups:
A gigantic performance gain in the FileFinder. readdir already tells you if the file is a directory so extra stat calls are nonsense.

For zegeris old test case this reduces the parsing time on Windows for me from 0.35 seconds to 0.000287 seconds (!)

This needs a test on all systems because readdir doesn't give this guarantee that the field is populated with useful data.
Can somebody test this under Linux? But I assume it works there.
Also Wii needs a test obviously.

At least on the 3DS it doesn't work but I already have a solution by looking at other sourcecode.

carstene1ns · 2016-04-03T09:24:40Z

http://stackoverflow.com/a/10376245 and also the first comment and last answer of it is interesting why we do it the way we did before this PR.

That said, it does not work under Linux currently.

carstene1ns · 2016-04-03T09:29:34Z

src/filefinder.cpp

@@ -593,8 +595,8 @@ FileFinder::Directory FileFinder::GetDirectoryMembers(const std::string& path, F
 #endif
 		if (name == "." || name == "..") { continue; }

-		bool is_directory = ent->d_type == S_IFDIR;
-
+		bool is_directory = S_ISDIR(ent->d_type);


ent->d_type == DT_DIR would work for me

Ghabry · 2016-04-03T11:53:13Z

I added a fallback mechanism now. So when testing you have to check the log now if you get a debug log about the system not supporting fast dir checks.
Or on the Wii if it takes now 10 minutes or only 10 seconds :P

Tondorian · 2016-04-03T12:23:56Z

now wii buld finds game and is fast, too

Ghabry · 2016-04-03T12:25:17Z

Great, I have two further, quite simple, optimisations under development that will give even more speed.
With them I reach 50 FPS on the old 3DS :)

carstene1ns · 2016-04-03T12:25:36Z

src/message_overlay.cpp

+	} else {
+		if (!show_all) {
+			return;
+		}
 	}


great little tweak!

…pulated.

…transparency of the image. Will prefer OP_SRC over _OVER when nothing is transparent.

… exists, otherwise with alpha. This saves an extra background graphic draw.

…d Map scene)

… bounds sprites.

Ghabry · 2016-04-03T23:02:27Z

About the new commits:
When blitting, the code checks now if the src bitmap is completely opaque and will do a OP_SRC instead of OP_OVER here. This also applies to single map tiles, most of them are blitted now via OP_SRC.

Additionally the background color of the system graphic is not rendered anymore for map scenes.

Sprites that would be rendered out of bounds are not rendered anymore.

All in all this gives a gigantic frame boost on the 3DS from 35 to 57 FPS on the world map of testgame.

…Title and is not really worth the FPS gain.

Ghabry · 2016-04-04T06:55:24Z

Don't merge yet. Found already an visual issue when the chipset is missing or has an invalid tile and doesn't render ^^ (AB blocks in testgame)

… transparent

…ecause the mask doesn't work otherwise.

…ments.

Ghabry · 2016-04-05T07:14:09Z

This and the battle PR are now finished (finally).
Expect enjoyable performance on all devices soon :D
lgtm?

carstene1ns · 2016-04-05T13:40:45Z

Is your filefinder change tested with games that have nested subdirectories? Otherwise LGTM.

Ghabry · 2016-04-05T13:43:50Z

I didn't try running any game. For this case I only checked zegeris subdirectory benchmark test case and the data structure showed the expected result.

Do you know any game that uses this feature?

Ghabry · 2016-04-05T16:36:37Z

I tested now: Chipset under "aaa\basis" is found and transparency of tiles in Embric: Works

Ghabry · 2016-04-05T16:55:15Z

RPG_RT.zip

Just checkout testgame 2000 and replace the stuff.

BlisterB · 2016-04-06T07:50:06Z

I tried this PR with the first town of Aedemphia.
Before : 9-25 fps
Now : 35-45 fps.

Improvements are clearly here, congratulation :) !

Ghabry · 2016-04-06T09:33:13Z

Great, this reflects my basic benchmarks which showed up to +33% in average (based on CPU usage, this doesn't scale linear with the FPS).
Corner cases with lots of blend and saturation effects and tons of events and picture effects have a hugher gain as you showed ^^

Ghabry added 3 commits April 1, 2016 22:07

Fix Visual Studio project files

fffef08

Speedup hardlight and saturation blits.

bfff812

Hard Light uses now a lookup table and the code is almost branch free. The table hurts the cache because of it's size but is faster then without cache because hard light requires branching. Saturation saves now one allocation and one OVER blit.

Speedup Fill and Clear by replacing fill_rectangles with OP_SRC/OP_CL…

9508041

…EAR Blit.

Zegeri reviewed Apr 2, 2016
View reviewed changes

Ghabry added 2 commits April 2, 2016 22:47

Reduce size of hard_light_lookup to uint8

1f32370

Make FileFinder super fast by getting rid of almost all "stat" calls …

101ac37

…while parsing.

Ghabry changed the title ~~Make HardLight, Saturation and Filll faster~~ Make HardLight, Saturation, Fill and FileFinder faster Apr 2, 2016

Ghabry force-pushed the fastblit branch from f4e2463 to e62b0d4 Compare April 2, 2016 23:20

carstene1ns reviewed Apr 3, 2016
View reviewed changes

src/message_overlay.cpp

} else {

if (!show_all) {

return;

}

}

Copy link

Member

carstene1ns Apr 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great little tweak!

Ghabry added 6 commits April 3, 2016 14:28

Add a fallback to filefinder to use slow "stat" when d_type is not po…

3a8b90f

…pulated.

Don't render MessageOverlay when it doesn't have any messages.

df9a27f

Determine blit operation for bitmap and tilemaps beforehand based on …

242234e

…transparency of the image. Will prefer OP_SRC over _OVER when nothing is transparent.

Make blitting on the Map smarter. Draw bottom opaque when no panorama…

188d567

… exists, otherwise with alpha. This saves an extra background graphic draw.

Only draw the system background when it is required (not for Title an…

703ef46

…d Map scene)

Simplify argument list for Sprite::BlitScreen and don't render out of…

b9c723c

… bounds sprites.

Ghabry force-pushed the fastblit branch from e9fca4d to b9c723c Compare April 3, 2016 22:52

Draw the background color for the title scene because this broke Hide…

59f0f54

…Title and is not really worth the FPS gain.

Ghabry added 3 commits April 4, 2016 22:00

Prevent render glitch when no panorama is rendered and a tile is full…

dcd2211

… transparent

GetOperator must take care of the mask. Set MaskedBlit back to OVER b…

0ed5bb3

…ecause the mask doesn't work otherwise.

Work around tone/sat not applied when a sprite was on a bush. Add com…

4527e6f

…ments.

fdelapena merged commit a713ce3 into EasyRPG:master Apr 5, 2016

Ghabry deleted the fastblit branch April 5, 2016 17:57

Ghabry modified the milestone: 0.4.2 Apr 11, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make HardLight, Saturation, Fill and FileFinder faster #855

Make HardLight, Saturation, Fill and FileFinder faster #855

Ghabry commented Apr 2, 2016

Ghabry commented Apr 2, 2016

BlisterB commented Apr 2, 2016

Zegeri Apr 2, 2016

Ghabry Apr 2, 2016

Ghabry commented Apr 2, 2016

carstene1ns commented Apr 3, 2016

carstene1ns Apr 3, 2016

Ghabry commented Apr 3, 2016

Tondorian commented Apr 3, 2016

Ghabry commented Apr 3, 2016

carstene1ns Apr 3, 2016

Ghabry commented Apr 3, 2016

Ghabry commented Apr 4, 2016

Ghabry commented Apr 5, 2016

carstene1ns commented Apr 5, 2016

Ghabry commented Apr 5, 2016

Ghabry commented Apr 5, 2016

Ghabry commented Apr 5, 2016

BlisterB commented Apr 6, 2016

Ghabry commented Apr 6, 2016

Make HardLight, Saturation, Fill and FileFinder faster #855

Make HardLight, Saturation, Fill and FileFinder faster #855

Conversation

Ghabry commented Apr 2, 2016

Ghabry commented Apr 2, 2016

BlisterB commented Apr 2, 2016

Zegeri Apr 2, 2016

Choose a reason for hiding this comment

Ghabry Apr 2, 2016

Choose a reason for hiding this comment

Ghabry commented Apr 2, 2016

carstene1ns commented Apr 3, 2016

carstene1ns Apr 3, 2016

Choose a reason for hiding this comment

Ghabry commented Apr 3, 2016

Tondorian commented Apr 3, 2016

Ghabry commented Apr 3, 2016

carstene1ns Apr 3, 2016

Choose a reason for hiding this comment

Ghabry commented Apr 3, 2016

Ghabry commented Apr 4, 2016

Ghabry commented Apr 5, 2016

carstene1ns commented Apr 5, 2016

Ghabry commented Apr 5, 2016

Ghabry commented Apr 5, 2016

Ghabry commented Apr 5, 2016

BlisterB commented Apr 6, 2016

Ghabry commented Apr 6, 2016