Add Nintendo 3DS port #869

Ghabry · 2016-04-19T14:25:26Z

Finally! Thanks to @Zegeri for the initial port and @Rinnegatamante for bringing the prototype in a usable state over the last weeks :).
Together with my performance improvments we went up from 16 FPS to ~56-59 FPS on old 3DS for the TestGame world map.

What makes this port special is that it does not depend on SDL and that it has a dedicated maintainer giving this port much more love.
This currently lacks MP3 and MIDI support, which will come later when mpg123 and fmmidi integration are pushed upstream.

Rinne is still adding code daily, so I suggest waiting a few more days and I will cherry pick his stuff... :)

This branch uses a slightly altered Makefile. Compile steps needed:

export TOOLCHAIN_DIR=[easyrpg_3ds_toolchain-dir]
# LIBLCF is extra because this is our lib and needs recompiles
export LIBLCF_DIR=[liblcf_crosscompile-dir]

cd builds/3ds
make -j2

Fixes #863

Ghabry · 2016-04-19T14:29:58Z

The commit order looks a bit wrong. Some of my commits are placed in between Rinnes o.O

Ghabry · 2016-04-19T14:31:15Z

But a local git log shows the correct order. Probably gets confused because of the dates.

Or here: https://github.com/Ghabry/easyrpg-player/commits/3ds

carstene1ns · 2016-04-19T14:36:51Z

src/graphics.cpp

@@ -117,7 +117,7 @@ void Graphics::Update(bool time_left) {
 		fps = 0;

 		next_fps_time = current_time + 1000;
-
+		


Rinnegatamante · 2016-04-19T16:46:00Z

A little thing. Release build should be compiled with -DNO_DEBUG and -DUSE_CACHE since right now NO_DEBUG will substitute bottom screen keyboard with a debug console and USE_CACHE allows usage of sounds cache (essential for a good stable framerate on a lot of games).

Ghabry · 2016-04-19T18:22:12Z

My build crashes on the 3DS but works in Citra :(

Rinnegatamante · 2016-04-19T18:52:12Z

My repository compiles fine and works, if you need, i can send you MD5 checksums for libctru/libsf2d/libkhax.

Ghabry · 2016-04-19T19:09:35Z

Which toolchain do you currently use? Could you try with the latest I linked in the forum: https://community.easyrpg.org/t/working-on-a-3ds-port/201

And did you compile your repository or my pull request?

Ghabry · 2016-04-21T18:01:15Z

Update: Found the crash reason \o/

Ghabry · 2016-04-21T19:59:26Z

The 3DS build is ready now and works 👍 . There are some toolchain problems but they are not Player related. Something with pixman is wrong, my older lib of it works. hm

Rinnegatamante · 2016-04-21T20:01:59Z

Nice! :P I think the icon i'm currently using in my repo is cooler however <.<

Ghabry · 2016-04-21T20:17:44Z

The problem with your icon is that it doesn't follow the EasyRPG branding. <.<
But you make a valid point because the HB launcher lacks background alpha

Rinnegatamante · 2016-04-21T20:20:46Z

It's just a zoomed version of the EasyRPG logo.

Ghabry · 2016-04-21T20:44:59Z

Replaced the icon with a rectangular one.

Rinnegatamante · 2016-04-21T22:27:53Z

I've noticed you have deleted the buildscript for CIA generation. What about it? It should be included in releases i think.

Ghabry · 2016-04-21T22:46:45Z

I skipped that commit because it contained lots of Windows binaries.
I will manually readd everything except the exe/dll files.

Jenkins will also offer a elf file to make creating CIAs easier.

gnmmarechal · 2016-04-21T22:52:08Z

Hum, you managed to actually put the whole icon in there. Although it probably will look weird on gridlauncher cuz the transparent part will be black. I'd rather have the zoomed-in one. In fact, the one I uploaded at my server for the easyRPG Updater to use if no icon is found is a zoomed-in EasyRPG icon (because pixelation occurs if I decrease the size of the icon too much). Also, I like the square.

Just looked at Ghabry's icon, looks different, but quite nice.

Ghabry · 2016-04-22T09:45:45Z

I want to replace the sample if the CIA channel with one that we also (plan) to use for the Wii channel.
I read on gbatemp that the maximal WAV length is 3 seconds. But I don't trust gbatemp and don't see this documented anywhere. Can you confirm @Rinnegatamante

Rinnegatamante · 2016-04-22T10:22:18Z

Not really 3 secs but something really near, like 3.4 secs. Also 3D models can be loaded so it could be cool to create a little model for the banner. (You can use Ohana 3DS to make it. A sample of 3D banner is in my CHMM/CHMM2 CIA version: https://youtu.be/ZoH2PQi71yo?t=4m38s i know it can also be animated but never tried so. This is the banner file of CHMM if it can help: https://github.com/Rinnegatamante/CHMM2/blob/master/banner.bin).

Ghabry · 2016-04-22T14:32:30Z

I ask @Rinnegatamante or @gnmmarechal to verify that the stuff in the cia_builder folder works. Especially the audio file. It is a 11025 Hz 16 PCM (Stereo). Compressed it quite heavy because I couldn't hear a difference.
I will provide an .elf later for testing romfs (from CIA) because I moved that code to main_data completely.

A 3D banner is out of scope for me currently. But should be considered later.

Rinnegatamante · 2016-04-22T15:05:58Z

hex_set is not a "released" tool but it's just a (really bad made) program that modifies Unique ID in workaround. Also the asked tools are not for common uses and a lot of people will not even know what PATH is.

Ghabry · 2016-04-22T15:25:38Z

That's why I wrote "or copy them in this directory". I expect from the users to know how to get the required stuff for CIA building.
Found the sourcecode of hex_set, this should be easy to replicate...

Except on Windows because batch sucks. Good that since Vista powershell is preinstalled.

Finally fixed all BGM_Pitch issues.

Bugfix for romFs support.

Re-introduced debug console.

Mapped Y button as Shift key.

Conflicts: src/audio_3ds.cpp src/main.cpp

…pace. This makes the 3dsx file 600 kbyte smaller.

… romfs missing.

Ghabry · 2016-04-26T20:17:21Z

okay now I know how to do it from the command line. I quickly pressed pause when a command line window popped up and looked in the taskmgr to figure out the command line. :D

… it has a use.

Ghabry · 2016-04-26T21:27:40Z

@Rinnegatamante or @gnmmarechal
Here is a new CIA: http://easyrpg.org/downloads/easyrpg-player-cia.zip Could you please test if this has the 3d banner of Rinne and a working sound effect?

Games are expected in sdmc:/3ds/easyrpg-player

carstene1ns · 2016-04-27T15:13:29Z

@Siltala reports the CIA shows the banner correctly and plays the sound fine, however it crashes on startup.

Ghabry · 2016-04-27T19:38:59Z

The download link in my previous post got updated

Rinnegatamante · 2016-04-27T20:53:34Z

So does the CIA still needs a test or not since it has been merged? I have enough time for a couple of tests if needed.

gnmmarechal · 2016-04-27T21:55:17Z

Awesome! The easyrpg updater now downloads the latest build from jenkins :)

Ghabry · 2016-04-28T06:58:31Z

@Rinnegatamante
We found somebody else in our IRC channel to do the test for us and he said it works :)

The elf is now also available in a zip archive. Please update your links to point to that zip, I will remove the gigantic elf in a day or two.

@gnmmarechal
You can extract the last build jenkins version via the XML or JSON Api:
https://ci.easyrpg.org/job/player-3ds/lastSuccessfulBuild/api/xml

lastBuiltRevision/SHA1 looks like a good candidate.

Then the updater can detect whether an update is needed or not by remembering that SHA1.

Or get the timestamp for displaying a human readable date. :D

gnmmarechal · 2016-04-28T12:45:13Z

@Ghabry I may implement that, but I don't know if it really is necessary - after all, it's a really small download anyway.

Ghabry · 2016-04-28T12:47:07Z

Well it is a useful information to the user imo. I don't care about the download, we have more then enough free traffic, I'm just suggesting some ideas if you should be bored and want to do more programming :D

gnmmarechal · 2016-04-28T12:51:07Z

I see. I may add it, whenever I get the time. Atm I have some more ideas
(ex. direct game download & installation, there's a ton of RPGM2k/2k3
freeware that I can add to make some sort of... PS Store for RPGs? I guess)

On Thu, Apr 28, 2016 at 1:47 PM, Ghabry notifications@github.com wrote:

Well it is a useful information to the user imo. I don't care about the
download, we have more then enough free traffic, I'm just suggesting some
ideas if you should be bored and want to do more programming :D

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#869 (comment)

Ghabry force-pushed the 3ds branch from 1c59004 to fbb4870 Compare April 19, 2016 14:34

carstene1ns reviewed Apr 19, 2016
View reviewed changes

src/graphics.cpp

@@ -117,7 +117,7 @@ void Graphics::Update(bool time_left) {

fps = 0;

next_fps_time = current_time + 1000;

Copy link

Member

carstene1ns Apr 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eeek

Ghabry force-pushed the 3ds branch from fbb4870 to f241cb4 Compare April 19, 2016 17:15

Ghabry force-pushed the 3ds branch 4 times, most recently from 3e9081a to d696a34 Compare April 21, 2016 19:57

Ghabry force-pushed the 3ds branch 2 times, most recently from 55e7707 to 2916847 Compare April 21, 2016 20:44

Rinnegatamante and others added 14 commits April 26, 2016 21:50

Finally fixed all BGM_Pitch issues.

e9ce4d8

Finally fixed all BGM_Pitch issues.

Bugfix for romFs support.

632ea92

Bugfix for romFs support.

Re-introduced debug console.

128a110

Re-introduced debug console.

Mapped Y button as Shift key.

25b84a9

Mapped Y button as Shift key.

3DS: Move DSP logic to Player and rename variable

0b7475b

Conflicts: src/audio_3ds.cpp src/main.cpp

3ds compile fixes

0ce1d35

Fix fmmidi for 3ds

558be59

3DS: Remove khax, is part of the 3DS toolchain

3af232d

3DS: Fix ogg/tremor. Update gitignore

564b7f0

3DS: Add link time codegen and strip unused functions. Cleanup whites…

5c030cc

…pace. This makes the 3dsx file 600 kbyte smaller.

CIA build won't share save_path anymore.

0b88e43

3DS: Update Makefile copyright. New icon.

8b2fb10

Add CIA builder by Rinnegatamante

69bceb7

3DS: Replace hex_set with powershell/sed. Use hardcoded CIA path when…

d1dde6a

… romfs missing.

Ghabry force-pushed the 3ds branch from 2150630 to 505a035 Compare April 26, 2016 20:43

Ghabry added 2 commits April 26, 2016 23:23

3DS: Add target XML with Youtube App as target. Remove freetype until…

f78b5c0

… it has a use.

3DS: Add 3d banner (Thx Rinnegatamante)

da1a485

Ghabry force-pushed the 3ds branch from 505a035 to da1a485 Compare April 26, 2016 21:24

fdelapena merged commit 77aa34c into EasyRPG:master Apr 27, 2016

Ghabry deleted the 3ds branch May 1, 2016 21:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Nintendo 3DS port #869

Add Nintendo 3DS port #869

Ghabry commented Apr 19, 2016

Ghabry commented Apr 19, 2016

Ghabry commented Apr 19, 2016 •

edited

Loading

carstene1ns Apr 19, 2016

Rinnegatamante commented Apr 19, 2016

Ghabry commented Apr 19, 2016

Rinnegatamante commented Apr 19, 2016 •

edited

Loading

Ghabry commented Apr 19, 2016 •

edited by fdelapena

Loading

Ghabry commented Apr 21, 2016

Ghabry commented Apr 21, 2016

Rinnegatamante commented Apr 21, 2016

Ghabry commented Apr 21, 2016

Rinnegatamante commented Apr 21, 2016

Ghabry commented Apr 21, 2016

Rinnegatamante commented Apr 21, 2016

Ghabry commented Apr 21, 2016

gnmmarechal commented Apr 21, 2016 •

edited

Loading

Ghabry commented Apr 22, 2016

Rinnegatamante commented Apr 22, 2016 •

edited

Loading

Ghabry commented Apr 22, 2016 •

edited

Loading

Rinnegatamante commented Apr 22, 2016

Ghabry commented Apr 22, 2016 •

edited

Loading

Ghabry commented Apr 26, 2016 •

edited

Loading

Ghabry commented Apr 26, 2016 •

edited by fdelapena

Loading

carstene1ns commented Apr 27, 2016

Ghabry commented Apr 27, 2016 •

edited

Loading

Rinnegatamante commented Apr 27, 2016

gnmmarechal commented Apr 27, 2016 •

edited

Loading

Ghabry commented Apr 28, 2016 •

edited by fdelapena

Loading

gnmmarechal commented Apr 28, 2016

Ghabry commented Apr 28, 2016

gnmmarechal commented Apr 28, 2016

		@@ -117,7 +117,7 @@ void Graphics::Update(bool time_left) {
		fps = 0;

		next_fps_time = current_time + 1000;

Add Nintendo 3DS port #869

Add Nintendo 3DS port #869

Conversation

Ghabry commented Apr 19, 2016

Ghabry commented Apr 19, 2016

Ghabry commented Apr 19, 2016 • edited Loading

carstene1ns Apr 19, 2016

Choose a reason for hiding this comment

Rinnegatamante commented Apr 19, 2016

Ghabry commented Apr 19, 2016

Rinnegatamante commented Apr 19, 2016 • edited Loading

Ghabry commented Apr 19, 2016 • edited by fdelapena Loading

Ghabry commented Apr 21, 2016

Ghabry commented Apr 21, 2016

Rinnegatamante commented Apr 21, 2016

Ghabry commented Apr 21, 2016

Rinnegatamante commented Apr 21, 2016

Ghabry commented Apr 21, 2016

Rinnegatamante commented Apr 21, 2016

Ghabry commented Apr 21, 2016

gnmmarechal commented Apr 21, 2016 • edited Loading

Ghabry commented Apr 22, 2016

Rinnegatamante commented Apr 22, 2016 • edited Loading

Ghabry commented Apr 22, 2016 • edited Loading

Rinnegatamante commented Apr 22, 2016

Ghabry commented Apr 22, 2016 • edited Loading

Ghabry commented Apr 26, 2016 • edited Loading

Ghabry commented Apr 26, 2016 • edited by fdelapena Loading

carstene1ns commented Apr 27, 2016

Ghabry commented Apr 27, 2016 • edited Loading

Rinnegatamante commented Apr 27, 2016

gnmmarechal commented Apr 27, 2016 • edited Loading

Ghabry commented Apr 28, 2016 • edited by fdelapena Loading

gnmmarechal commented Apr 28, 2016

Ghabry commented Apr 28, 2016

gnmmarechal commented Apr 28, 2016

Ghabry commented Apr 19, 2016 •

edited

Loading

Rinnegatamante commented Apr 19, 2016 •

edited

Loading

Ghabry commented Apr 19, 2016 •

edited by fdelapena

Loading

gnmmarechal commented Apr 21, 2016 •

edited

Loading

Rinnegatamante commented Apr 22, 2016 •

edited

Loading

Ghabry commented Apr 22, 2016 •

edited

Loading

Ghabry commented Apr 22, 2016 •

edited

Loading

Ghabry commented Apr 26, 2016 •

edited

Loading

Ghabry commented Apr 26, 2016 •

edited by fdelapena

Loading

Ghabry commented Apr 27, 2016 •

edited

Loading

gnmmarechal commented Apr 27, 2016 •

edited

Loading

Ghabry commented Apr 28, 2016 •

edited by fdelapena

Loading