Replace the Boost preprocessor stuff with a jinja2-template #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghabry
force-pushed
the
boost-pp-go-away
branch
from
388e7a2
to
380cf16
Compare
|
I find this much more readable and it's always good to remove boost dependencies. No reason to use macro tricks when we're already doing python/jinja2 codegen. |
fdelapena
approved these changes
Sep 27, 2018
Ghabry
changed the title
Ghabry
force-pushed
the
boost-pp-go-away
branch
3 times, most recently
from
39f1ce2
to
7e782ee
Compare
|
Reran my test scripts, the results stay the same. |
fdelapena
approved these changes
Nov 5, 2018
fmatthew5876
approved these changes
Nov 5, 2018
|
hmpf, why does this need a rebase again :/ |
Is from a time where our templates were not scriptable.
Ghabry
force-pushed
the
boost-pp-go-away
branch
from
7e782ee
to
90de0ca
Compare
|
Any reason not to merge this? I can rebase my stuff as needed. |
carstene1ns
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because our templates are now not simple string replacements anymore but scriptable.
This makes the code more verbose but it improves the readability imo because the complexity behind the templates is not hidden anymore.