Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the Boost preprocessor stuff with a jinja2-template #238

Merged
merged 1 commit into from Nov 29, 2018

Conversation

Projects
None yet
4 participants
@Ghabry
Copy link
Member

Ghabry commented Sep 27, 2018

Because our templates are now not simple string replacements anymore but scriptable.

This makes the code more verbose but it improves the readability imo because the complexity behind the templates is not hidden anymore.

@Ghabry Ghabry force-pushed the Ghabry:boost-pp-go-away branch from 388e7a2 to 380cf16 Sep 27, 2018

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

fmatthew5876 commented Sep 27, 2018

I find this much more readable and it's always good to remove boost dependencies. No reason to use macro tricks when we're already doing python/jinja2 codegen.

@fdelapena fdelapena added this to the 0.6.0 milestone Oct 4, 2018

@Ghabry Ghabry changed the title [Don't merge, conflicts!] Replace the Boost preprocessor stuff with a jinja2-template Replace the Boost preprocessor stuff with a jinja2-template Nov 4, 2018

@Ghabry Ghabry force-pushed the Ghabry:boost-pp-go-away branch 3 times, most recently from 39f1ce2 to 7e782ee Nov 5, 2018

@Ghabry Ghabry removed the Needs Rebase label Nov 5, 2018

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Nov 5, 2018

Reran my test scripts, the results stay the same.

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Nov 26, 2018

hmpf, why does this need a rebase again :/

Replace the Boost preprocessor stuff with a jinja2-template.
Is from a time where our templates were not scriptable.

@Ghabry Ghabry force-pushed the Ghabry:boost-pp-go-away branch from 7e782ee to 90de0ca Nov 26, 2018

@fdelapena fdelapena added Refactor and removed Needs Rebase labels Nov 26, 2018

@fmatthew5876

This comment has been minimized.

Copy link
Contributor

fmatthew5876 commented Nov 28, 2018

Any reason not to merge this? I can rebase my stuff as needed.

@carstene1ns carstene1ns merged commit 0fa3a80 into EasyRPG:master Nov 29, 2018

4 checks passed

GNU/Linux Build finished.
Details
OSX Build finished.
Details
Windows Build finished.
Details
web Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.