Savegame move speed default is 4 and not 3 #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix EasyRPG/Player #1650
fdelapena
approved these changes
Mar 1, 2019
fmatthew5876
approved these changes
Mar 1, 2019
carstene1ns
approved these changes
Mar 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix EasyRPG/Player#1650
The only way to trigger this is by manually killing the chunk in a hex editor or by saving with Player 0.5.4 which omits the chunk and assumes 4 as default (the chunk is persitent, even when defaulted). Now the hero has normal speed after loading an old save.
Guess this was changed by accident during refactor because the Move speed in the LDB has 3 as default... Not very consistent.