-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the GNU extensions #366
Conversation
Is it possible to update newlib? |
I'm not part of the OS4 developer team, so I can't update it. I want to avoid hacking the SDK headers, because it would create a big mess, especially for others who would like to build liblcf, I might break other software, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well can't comment further on this as I don't know if gnu++14 has any disadvantages for us.
In case we accidentally use some GNU extension in code, |
I believe the only downside is that we if we use some gnu extension by mistake, non-gnu builds will fail. But then we'll see it in jenkins. So I'm fine with this. |
I'd like to get this nastiness:
https://github.com/EasyRPG/liblcf/blob/master/src/writer_xml.cpp#L12
The problem is what
-std=c++11
defines__STRICT_ANSI__
which causes a lot of functions to go undeclared on AmigaOS4. I made this a separate PR in case it causes any problems.