Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the GNU extensions #366

Merged
merged 1 commit into from
May 14, 2020
Merged

Enable the GNU extensions #366

merged 1 commit into from
May 14, 2020

Conversation

BSzili
Copy link
Contributor

@BSzili BSzili commented Apr 23, 2020

I'd like to get this nastiness:
https://github.com/EasyRPG/liblcf/blob/master/src/writer_xml.cpp#L12
The problem is what -std=c++11 defines __STRICT_ANSI__ which causes a lot of functions to go undeclared on AmigaOS4. I made this a separate PR in case it causes any problems.

@Ghabry
Copy link
Member

Ghabry commented Apr 23, 2020

Is it possible to update newlib?
They fixed these macros 4 years ago: bminor/newlib@feec81e

@BSzili
Copy link
Contributor Author

BSzili commented Apr 24, 2020

I'm not part of the OS4 developer team, so I can't update it. I want to avoid hacking the SDK headers, because it would create a big mess, especially for others who would like to build liblcf, I might break other software, etc.
Unfortunately this seems to be the only way to be compatible with the official OS4 SDK without resorting to workarounds I added previously.

Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well can't comment further on this as I don't know if gnu++14 has any disadvantages for us.

@fdelapena
Copy link
Contributor

fdelapena commented Apr 26, 2020

In case we accidentally use some GNU extension in code, clang MSVC automated builds not based on autotools/cmake might fail, so maybe it's safe.

@fmatthew5876
Copy link
Contributor

I believe the only downside is that we if we use some gnu extension by mistake, non-gnu builds will fail. But then we'll see it in jenkins.

So I'm fine with this.

CMakeLists.txt Show resolved Hide resolved
@carstene1ns carstene1ns merged commit 48e1b61 into EasyRPG:master May 14, 2020
@carstene1ns carstene1ns added this to the 0.6.3 milestone May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

5 participants