Initial cut at rebranded site #7

drluckyspin · 2019-12-09T22:18:38Z

First tranche of work to rebrand the micro site. Mostly focused on styling and content of home page.

chrisguindon

This is awesome! Thanks for contributing a PR to this project!

Here's a preview of this PR:
https://deploy-preview-7--eclipsefdn-edgenative.netlify.com/

Please note that I will need a +1 from our marketing team before I can pull this in. I need to make sure that this change does not interfere with any of their marketing effort that are planned for this week!

But for now, I can provide some feedback on the code since that's my department :)

General comments:

Can we please shrink the size of +325 KB static/images/bg_hero01.png. The current image is 57 KB.
Can we reduce our usage of the !important statement? Whenever possible, please override our variables: https://github.com/EclipseFdn/solstice-assets/blob/master/less/quicksilver/_variables.less
I don't believe we are allowed to grayscale logo of our members.
Please fix the git conflict with the data/testimonials.yml file.

chrisguindon · 2019-12-09T23:18:46Z

content/_index.md

@@ -37,7 +37,7 @@ container: "container-fluid"
 <!-- start: Founding Members -->
 <div id="members" class="row featured-section featured-section-members">
  <div class="container">
-  <h2>Founding Members</h2>
+  <h2 class="section-title">Founding Members</h2>


Nit pick: Can we avoid introducing a new css class here?

If possible, I would prefer to keep our html simple so that we can easily re-use the featured-section component.

data/members.yml

chrisguindon · 2019-12-09T23:38:59Z

less/styles.less

+}
+
+.founder-logo {
+  filter: grayscale(1) contrast(0)


I don't believe we are allowed to alter logos from our members. I would recommend that we remove this line.

Really? This has become pretty standard fair on modern websites. Here's an example of (black this time) treatment on logos at Hashicorp's site:

https://www.hashicorp.com/

We can remove if it's a blocker, but certain is aesthetically more pleasing within the design ;)

I agree this is way nicer but it's a blocker.

Altering a company logo is not something that someone should do without proper permission.

Most brand usage guideline will require you to use their grayscale version of their logo.

We should ask our members to supply a grayscale version of their logo if we need it on the website!

chrisguindon · 2019-12-10T00:44:23Z

A few other comments:

I think we should stick with our current tagline: Open Edge Native Platforms Now. I don’t think we need to put a negative spin on specs on this website. I quickly discussed with the tagline with Thabang and we may want try something like “Your Production Edge Platform. Now.”
Can we improve the contrast in the jumbotron. I find the text a bit hard to read now with this new background image.
Since we are changing the colors, can you supply a new favicon and new social media image:

https://github.com/EclipseFdn/edgenative.eclipse.org/blob/master/static/images/edgenative/favicon/favicon.ico

https://github.com/EclipseFdn/edgenative.eclipse.org/blob/master/static/images/edgenative/edge-logo-social.png

chrisguindon · 2019-12-10T01:18:39Z

I have a +1 from Thabang to move forward with this new look and feel if the critical feedback is addressed:

Remove grayscale on member logos
Revert tagline or replace with “Your Production Edge Platform. Now.”
Contribute new favicon and social media image.
Improve contrast in jumbotron so that the non-bolded text is easier to read
Reduce the size of the jumbotron background image. 325 KB is quite big.
Fix git conflict (rebase) since we can't merge this PR as is.

Nit picks, i.e classname, are things that we can address/refactor at a later time.

netlify · 2019-12-10T02:07:20Z

Deploy preview for eclipsefdn-edgenative ready!

Built with commit f064e20

https://deploy-preview-7--eclipsefdn-edgenative.netlify.com

drluckyspin · 2019-12-10T02:07:44Z

Comments:

1: See above about Grayscale. Easy to remove/replace.
2. The old tagline was VERY confusing. We'll definitely put something more aspirational though.
3. Will update the images/icons needed.
4. We'll try and play with contrast.. but not sure which bit is troubling for you right now.
5. Can reduce the image size.
6. Will fix the merge.

chrisguindon · 2019-12-10T02:28:00Z

Comments:

1: See above about Grayscale. Easy to remove/replace.

+1 to remove for now and let's ask our members to send us their approved grayscale logo.

The old tagline was VERY confusing. We'll definitely put something more aspirational though.

Thabang gave me his approval to move forward if the tagline is reverted or updated to Your Production Edge Platform. Now.”

I probably won't be able to talk to him again tonight so hopefully we can keep this simple for today since we can always change it again tomorrow.

Will update the images/icons needed.
thanks!

We'll try and play with contrast.. but not sure which bit is troubling for you right now.

Bolded text in the jumbotron is ok but the tagline is hard to read "Delivering code, not specs". The quick fix might be to bold the tagline.

Tomorrow, we will ask our designer @ChristieWittEclipse, for her recommendation in regards to accessibility/contrast!

Can reduce the image size.

Will fix the merge.

Thanks

drluckyspin · 2019-12-10T02:33:48Z

Re: tagline: How about "Deploying Open Source Edge Platforms. Now."?

What browser are you using to view the tagline? It seems very clear on the ones we're testing with. We can always make the text heavier.

chrisguindon · 2019-12-10T02:42:23Z

Re: tagline: How about "Deploying Open Source Edge Platforms. Now."?

This sounds good to me but it's not my call.

I sent a message to Thabang for approval but I think we should play it safe for now and use "Open Edge Native Platforms Now" until we get his approval for the new tagline.

chrisguindon · 2019-12-10T02:45:40Z

What browser are you using to view the tagline? It seems very clear on the ones we're testing with. We can always make the text heavier.

Chrome. I think we are good if we add a bit font-weight to the tagline.

chrisguindon · 2019-12-10T03:08:33Z

Are you experiencing issues with the rebase?

May I suggest that we squash these 21 commits into 1.

I would prefer we do that so that I can quickly revert to the old site by reverting 1 commit if a problem is uncovered.

ThabangMash · 2019-12-10T03:08:38Z

Re: tagline: How about "Deploying Open Source Edge Platforms. Now."?

This sounds good to me but it's not my call.

I sent a message to Thabang for approval but I think we should play it safe for now and use "Open Edge Native Platforms Now" until we get his approval for the new tagline.

Deploying feels off the mark. How about Delivering?
"Delivering Open Source Edge Platforms. Now."

drluckyspin · 2019-12-10T03:15:56Z

Delivering it is!

chrisguindon · 2019-12-10T03:20:47Z

@drluckyspin It's starting to be late here, do you have an ETA for when I should expect everything to be ready to be merged?

Pixcell · 2019-12-10T03:30:24Z

Hi @chrisguindon ,

thank you for your patience ! We are almost done ! Last bit is to check that the News and event are ok. But we cannot seem to populate them

Any tips ?

drluckyspin · 2019-12-10T03:30:32Z

Last remaining thing is the favicon and social graphic. Being worked on right now.

Tweaks the mission statement and keywords Initial cut of new style variables

Updated all svg logos to correct color palette.

chrisguindon · 2019-12-10T03:36:56Z

hi @Pixcell,

The event is showing here: https://deploy-preview-7--eclipsefdn-edgenative.netlify.com/

This preview is built with hugo 0.54.0: https://github.com/EclipseFdn/edgenative.eclipse.org/blob/master/netlify.toml

A different version of hugo might cause the page to render differently. The clock on your computer might also affect what content is ready to be published on the website.

You should be able to see a news item by adding a news item in content/news/example.md

For example:
https://github.com/EclipseFdn/hugo-solstice-theme/tree/master/exampleSite/content/news

Pixcell · 2019-12-10T03:52:42Z

Thanks @chrisguindon ,

Looks good to me, just waiting on @drluckyspin favicons and we should be good to go.

Side note, I built the docker image (to use Hugo 0.54 instead of 0.60 that I have locally installed) and it didn't pick up our style changes. Any idea why ?

drluckyspin · 2019-12-10T03:55:43Z

Fav icons are in.. rest of images coming now. That's the last bit I think

chrisguindon · 2019-12-10T03:59:29Z

Side note, I built the docker image (to use Hugo 0.54 instead of 0.60 that I have locally installed) and it didn't pick up our style changes. Any idea why ?

Did you build the image more than once? If so, you might need build with the 'no-cache' option to make sure that build runs

edgenative.eclipse.org/Dockerfile

Line 32 in cb96061

RUN npm --unsafe-perm ci \

chrisguindon · 2019-12-10T04:04:17Z

@drluckyspin @Pixcell will you squash all the commits into one or do you prefer I do it via github?

drluckyspin · 2019-12-10T04:04:37Z

@chrisguindon Everything is in and done! Thanks for your patience.

Pixcell · 2019-12-10T04:04:50Z

@drluckyspin @Pixcell will you squash all the commits into one or do you prefer I do it via github?

Feel free do it via github

chrisguindon · 2019-12-10T04:07:14Z

Thanks to you both for all of this work! I really think that it's awesome that you guys stepped up and contributed this code to improve the website!

Give me a few minutes to do a final review and I will merge the change if all is well!

chrisguindon · 2019-12-10T04:14:56Z

The changes were committed! It should take about 15 minutes to see them on production!

Pixcell · 2019-12-10T04:16:11Z

@chrisguindon Thanks for your patience and advices !

drluckyspin · 2019-12-10T04:16:42Z

@chrisguindon Thanks dude! The site is looking really good!

Next up.. taking a look at the FAQ page ;) But that's for another day..

chrisguindon · 2019-12-10T04:22:33Z

Keep these PR coming! I am 100% supportive for helping out folks in our community who wishes to collaborate on our websites!

Again, thank you so much for pushing this forward and I am looking forward to working with you guys in the future!

chrisguindon suggested changes Dec 9, 2019

View reviewed changes

Pixcell force-pushed the master branch from c85d39d to b044eeb Compare December 10, 2019 02:06

drluckyspin and others added 14 commits December 10, 2019 16:31

Adds support for newer versions of Hugu.

5c0c7ac

Tweaks the mission statement and keywords Initial cut of new style variables

New background image for title header

5561aed

Fix Mission Statement section.

aafa8af

Updated all svg logos to correct color palette.

Logo gray

09037e7

adlink rename

5acb10b

WIP: Testimonials

c414bdb

Add .idea rule to .gitignore.

ff2c2b0

Testimonials

68fec45

Re-order menu items.

6bca1d8

Switched profile overlay to have a blue tinge.

a9fb48f

Switched profile overlay to have a blue tinge.

7bc0508

Update gradients

c280df7

adlink rename

da2de82

WIP: Testimonials

2eb1083

drluckyspin and others added 8 commits December 10, 2019 16:31

Fix adlink logo filename

249f62e

Remove grayscale and pad mission statement.

454f3bb

Update tagline.

9691e6c

Update testimonies to put faces

028bc03

Style buttons

19ae7b8

Re-order testimonials

922bed2

Fixed tagline, again!

ce98e37

Remove match-height-item for testimonials

65c2695

Pixcell force-pushed the master branch from 5aa403c to 65c2695 Compare December 10, 2019 03:36

Remove section-title classe

3c75e46

Add pink favicon files.

61976de

drluckyspin added 2 commits December 9, 2019 19:57

Now with the Chrome ones too.

5b8507a

Reduce size of header background image.

1c7ecbc

Pixcell and others added 2 commits December 10, 2019 17:00

Remove inverted-title classe

9c57d20

Social logo now has pink background.

f064e20

chrisguindon approved these changes Dec 10, 2019

View reviewed changes

chrisguindon merged commit 743fed2 into EclipseFdn:master Dec 10, 2019

chrisguindon mentioned this pull request Dec 10, 2019

Improve accessibility (contrast) on Edge Native website #12

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial cut at rebranded site #7

Initial cut at rebranded site #7

drluckyspin commented Dec 9, 2019

chrisguindon left a comment

chrisguindon Dec 9, 2019 •

edited

Loading

chrisguindon Dec 9, 2019 •

edited

Loading

drluckyspin Dec 10, 2019

chrisguindon Dec 10, 2019 •

edited

Loading

chrisguindon Dec 10, 2019

drluckyspin Dec 10, 2019

chrisguindon commented Dec 10, 2019 •

edited

Loading

chrisguindon commented Dec 10, 2019 •

edited

Loading

netlify bot commented Dec 10, 2019 •

edited

Loading

drluckyspin commented Dec 10, 2019

chrisguindon commented Dec 10, 2019 •

edited

Loading

drluckyspin commented Dec 10, 2019

chrisguindon commented Dec 10, 2019

chrisguindon commented Dec 10, 2019 •

edited

Loading

chrisguindon commented Dec 10, 2019

ThabangMash commented Dec 10, 2019

drluckyspin commented Dec 10, 2019

chrisguindon commented Dec 10, 2019

Pixcell commented Dec 10, 2019

drluckyspin commented Dec 10, 2019

chrisguindon commented Dec 10, 2019 •

edited

Loading

Pixcell commented Dec 10, 2019

drluckyspin commented Dec 10, 2019

chrisguindon commented Dec 10, 2019 •

edited

Loading

chrisguindon commented Dec 10, 2019

drluckyspin commented Dec 10, 2019

Pixcell commented Dec 10, 2019

chrisguindon commented Dec 10, 2019

chrisguindon commented Dec 10, 2019

Pixcell commented Dec 10, 2019

drluckyspin commented Dec 10, 2019

chrisguindon commented Dec 10, 2019

Initial cut at rebranded site #7

Initial cut at rebranded site #7

Conversation

drluckyspin commented Dec 9, 2019

chrisguindon left a comment

Choose a reason for hiding this comment

chrisguindon Dec 9, 2019 • edited Loading

Choose a reason for hiding this comment

chrisguindon Dec 9, 2019 • edited Loading

Choose a reason for hiding this comment

drluckyspin Dec 10, 2019

Choose a reason for hiding this comment

chrisguindon Dec 10, 2019 • edited Loading

Choose a reason for hiding this comment

chrisguindon Dec 10, 2019

Choose a reason for hiding this comment

drluckyspin Dec 10, 2019

Choose a reason for hiding this comment

chrisguindon commented Dec 10, 2019 • edited Loading

chrisguindon commented Dec 10, 2019 • edited Loading

netlify bot commented Dec 10, 2019 • edited Loading

drluckyspin commented Dec 10, 2019

chrisguindon commented Dec 10, 2019 • edited Loading

drluckyspin commented Dec 10, 2019

chrisguindon commented Dec 10, 2019

chrisguindon commented Dec 10, 2019 • edited Loading

chrisguindon commented Dec 10, 2019

ThabangMash commented Dec 10, 2019

drluckyspin commented Dec 10, 2019

chrisguindon commented Dec 10, 2019

Pixcell commented Dec 10, 2019

drluckyspin commented Dec 10, 2019

chrisguindon commented Dec 10, 2019 • edited Loading

Pixcell commented Dec 10, 2019

drluckyspin commented Dec 10, 2019

chrisguindon commented Dec 10, 2019 • edited Loading

chrisguindon commented Dec 10, 2019

drluckyspin commented Dec 10, 2019

Pixcell commented Dec 10, 2019

chrisguindon commented Dec 10, 2019

chrisguindon commented Dec 10, 2019

Pixcell commented Dec 10, 2019

drluckyspin commented Dec 10, 2019

chrisguindon commented Dec 10, 2019

chrisguindon Dec 9, 2019 •

edited

Loading

chrisguindon Dec 9, 2019 •

edited

Loading

chrisguindon Dec 10, 2019 •

edited

Loading

chrisguindon commented Dec 10, 2019 •

edited

Loading

chrisguindon commented Dec 10, 2019 •

edited

Loading

netlify bot commented Dec 10, 2019 •

edited

Loading

chrisguindon commented Dec 10, 2019 •

edited

Loading

chrisguindon commented Dec 10, 2019 •

edited

Loading

chrisguindon commented Dec 10, 2019 •

edited

Loading

chrisguindon commented Dec 10, 2019 •

edited

Loading