This repository has been archived by the owner on Mar 15, 2022. It is now read-only.
add ARM to user member #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
|
✔️ Deploy preview for eclipsefdn-openadx ready! 🔨 Explore the source changes: 1cf1c31 🔍 Inspect the deploy logs: https://app.netlify.com/sites/eclipsefdn-openadx/deploys/5fd3d30a516c930007dfc3b2 😎 Browse the preview: https://deploy-preview-126--eclipsefdn-openadx.netlify.app |
|
LGTM, add as reviewer to get sign off + merge. Will wait for description |
@autumnfound Just confirmed with Zahra on slack and she is good with this, thanks for checking! |
flora8984461
requested review from
autumnfound,
chrisguindon and
ericpoirier
|
Wait, I just noticed there is already a PR for it #124 |
Signed-off-by: Yi Liu <yi.liu@eclipse-foundation.org>
ariexi
approved these changes
Dec 17, 2020
|
.. @ariexi and I just notice your comment :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #125
Signed-off-by: Yi Liu yi.liu@eclipse-foundation.org