Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KW_Variables #67

Merged
merged 21 commits into from
Feb 26, 2024
Merged

KW_Variables #67

merged 21 commits into from
Feb 26, 2024

Conversation

kewalak
Copy link
Contributor

@kewalak kewalak commented Feb 16, 2024

Some changes:

  • Changed all _T to _tc and all water_temp_c to TwaterC
  • Changed Kac_T to ka_tc
  • Wrote in theta values for temperature corrections
  • Removed duplicate defined variables and changed names for variables to be consistent (example p_atm to pressure_atm)
  • Created variables for the flow models such as velocity, flow, etc.
  • Added calculations for global parameters
  • Created constant list
  • Updated imported modules and file headings
  • Updated some IF statements to xr.where statements

@kewalak kewalak requested a review from imscw95 February 16, 2024 22:47
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: Patch coverage is 5.40541% with 350 lines in your changes are missing coverage. Please review.

Project coverage is 42.92%. Comparing base (05898a3) to head (1e7b2ff).
Report is 3 commits behind head on main.

❗ Current head 1e7b2ff differs from pull request most recent head 9c02929. Consider uploading reports for the commit 9c02929 to get more accurate results

Files Patch % Lines
src/clearwater_modules/nsm1/constants.py 0.00% 108 Missing ⚠️
src/clearwater_modules/nsm1/model.py 0.00% 99 Missing ⚠️
...c/clearwater_modules/nsm1/test_nsm1_static_vars.py 0.00% 98 Missing ⚠️
...clearwater_modules/nsm1/static_variables_global.py 0.00% 20 Missing ⚠️
src/clearwater_modules/nsm1/state_variables.py 0.00% 13 Missing ⚠️
src/clearwater_modules/shared/processes.py 47.82% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   39.36%   42.92%   +3.55%     
==========================================
  Files          33       23      -10     
  Lines        1138     1095      -43     
==========================================
+ Hits          448      470      +22     
+ Misses        690      625      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kewalak kewalak merged commit f214fe3 into main Feb 26, 2024
1 check passed
@kewalak kewalak deleted the KW_Variables branch February 26, 2024 21:16
@aufdenkampe aufdenkampe added this to the NSM Initial Release milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants