Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AA-1007] Use azure artifact feed #124

Merged
merged 4 commits into from
Jan 14, 2021
Merged

Conversation

andonyns
Copy link
Contributor

@andonyns andonyns commented Jan 7, 2021

  • Use prerelease version of AppCommon with changes to use Azure Artifacts
  • Change URLs to use azure artifacts

@andonyns andonyns requested a review from CSR2017 January 7, 2021 22:09
@CLAassistant
Copy link

CLAassistant commented Jan 7, 2021

CLA assistant check
All committers have signed the CLA.

@andonyns andonyns requested review from CSR2017 and removed request for CSR2017 January 7, 2021 22:12
@@ -14,7 +14,7 @@ $ErrorActionPreference = "Stop"
Push-Location $PackageDirectory

$dependencyVersions = @{
AppCommon = "1.1.0"
AppCommon = "1.1.0-pre1138"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure we have a Tracker ticket for release preparation tasks, and that one of the acceptance criteria is updating this script to the full release.

Separately, we need to change the version number on AppCommon - we have already released 1.1.0, so it doesn't make sense to have new pre-releases of 1.1.0 😆 . Need to bump to 1.2.0. I will look into that, as I'm already working on a ticket that includes an update to AppCommon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.2.0 update: done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, 1.1.0-pre1138 is the build for my TSINSTALL-88 ticket, which has not yet been reviewed. So this ticket should probably wait for merge until TSINSTALL-88 is done, which hopefully will be this morning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created https://tracker.ed-fi.org/browse/AA-1218 to track the package update as one of the final steps before the release

@andonyns andonyns force-pushed the AA-1007-use-azure-artifact-feed branch from 2c37ee2 to 9bcaeb7 Compare January 14, 2021 21:02
@andonyns andonyns force-pushed the AA-1007-use-azure-artifact-feed branch from 9bcaeb7 to 0d08543 Compare January 14, 2021 21:10
@CSR2017 CSR2017 merged commit b8b435f into main Jan 14, 2021
@CSR2017 CSR2017 deleted the AA-1007-use-azure-artifact-feed branch January 14, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants