-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AA-1007] Use azure artifact feed #124
Conversation
andonyns
commented
Jan 7, 2021
- Use prerelease version of AppCommon with changes to use Azure Artifacts
- Change URLs to use azure artifacts
@@ -14,7 +14,7 @@ $ErrorActionPreference = "Stop" | |||
Push-Location $PackageDirectory | |||
|
|||
$dependencyVersions = @{ | |||
AppCommon = "1.1.0" | |||
AppCommon = "1.1.0-pre1138" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure we have a Tracker ticket for release preparation tasks, and that one of the acceptance criteria is updating this script to the full release.
Separately, we need to change the version number on AppCommon - we have already released 1.1.0, so it doesn't make sense to have new pre-releases of 1.1.0 😆 . Need to bump to 1.2.0. I will look into that, as I'm already working on a ticket that includes an update to AppCommon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.2.0 update: done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, 1.1.0-pre1138
is the build for my TSINSTALL-88 ticket, which has not yet been reviewed. So this ticket should probably wait for merge until TSINSTALL-88 is done, which hopefully will be this morning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created https://tracker.ed-fi.org/browse/AA-1218 to track the package update as one of the final steps before the release
a603347
to
2c37ee2
Compare
2c37ee2
to
9bcaeb7
Compare
9bcaeb7
to
0d08543
Compare