Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Fix 9878 group suggestion link #10127

Merged
merged 12 commits into from
Jan 12, 2024
Merged

Conversation

sital002
Copy link
Member

Fixes Issue

fixes #9878

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@sital002
Copy link
Member Author

@eddiejaoude the #9878 pr is breaking the links page i reverted the changes and made the fix can u look into this

@sital002
Copy link
Member Author

sital002 commented Jan 12, 2024

The previous PR would break the add new link page if i already have links but don't have any group since i am returing a object if no group found here and trying to call slice method on the object here i should have returned an array instead.
I have fixed those changes here.

components/GroupLinkSearch.js Show resolved Hide resolved
@@ -30,6 +34,12 @@ export async function getServerSideProps(context) {
const id = context.query.data ? context.query.data[0] : undefined;

let link = {};
let groups = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe linkGroups is a beter name, than it's clear what kind of groups this variable holds

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@eddiejaoude eddiejaoude merged commit 3de1e09 into EddieHubCommunity:main Jan 12, 2024
13 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants