Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the Issue #10203 - The icon drop-down suggestions are not visible properly #10232

Merged
merged 1 commit into from Mar 2, 2024

Conversation

chetannada
Copy link
Contributor

@chetannada chetannada commented Feb 12, 2024

Closes #10203

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Normal Mode:
111

Dark Mode:
222

Note to reviewers

I have added a screenshot, and it's working fine in both normal and dark mode.

Icon drop-down suggestions are not visible properly - fixed the Issue 10203
@chetannada chetannada changed the title Fixed the Issue #10203 Fixed the Issue #10203 - The icon drop-down suggestions are not visible properly Feb 12, 2024
@SaraJaoude SaraJaoude added the issue linked Pull Request has issue linked label Feb 13, 2024
Copy link

@luismr00 luismr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only line that needed to be adjusted to fix the problem. Although, the options do not overlap on top of the elements below such as the save button anymore. Instead it pushes the elements below once it shows all the searched options. In my opinion it looks better but will leave it up to the maintainers to agree and approve.
Screenshot 2024-02-15 at 1 09 35 PM (2)
Screenshot 2024-02-15 at 1 09 47 PM (2)

Copy link

@luismr00 luismr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the new changes and works well 👍

@chetannada
Copy link
Contributor Author

Verified the new changes and works well 👍

Thanks 👍

@chetannada
Copy link
Contributor Author

Hi @SaraJaoude @eddiejaoude
Any update on this PR? because it's 3 weeks old!

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Chetan! Thanks for Contributing! 🎉

@kumarsonsoff3 kumarsonsoff3 merged commit 51b9c12 into EddieHubCommunity:main Mar 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue linked Pull Request has issue linked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Icon drop-down suggestions are not visible properly
5 participants