Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Typo in pages/icons.js #10256

Merged
merged 1 commit into from Mar 13, 2024
Merged

fix: Typo in pages/icons.js #10256

merged 1 commit into from Mar 13, 2024

Conversation

PrajvalaRC
Copy link
Contributor

Fixes Issue

Closes #10249

Changes proposed

Typo is fixed. filterredIcons is modified to filteredIcons

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

@github-actions github-actions bot added the issue linked Pull Request has issue linked label Mar 8, 2024
badrivlog
badrivlog approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@badrivlog badrivlog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

sital002
sital002 approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@sital002 sital002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thank you for the contribution

kumarsonsoff3
kumarsonsoff3 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks for contributing! 🎉

@kumarsonsoff3 kumarsonsoff3 merged commit d7b4ec6 into EddieHubCommunity:main Mar 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badrivlog badrivlog badrivlog approved these changes

@kumarsonsoff3 kumarsonsoff3 kumarsonsoff3 approved these changes

@sital002 sital002 sital002 approved these changes

Assignees
No one assigned
Labels
issue linked Pull Request has issue linked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Typo in pages/icons.js
4 participants
@PrajvalaRC @badrivlog @kumarsonsoff3 @sital002