Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cannot save profile after adding tags #10337

Closed
1 task done
Abiheb opened this issue Apr 16, 2024 · 8 comments
Closed
1 task done

[BUG] Cannot save profile after adding tags #10337

Abiheb opened this issue Apr 16, 2024 · 8 comments
Labels
🛠 goal: fix undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@Abiheb
Copy link

Abiheb commented Apr 16, 2024

Has this bug been raised before?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?

Production on biodrop.io

Version of BioDrop (for example "v1.2.3")

v2.100.2

Description

When attempting to add new tags to my profile, I am unable to save the changes. The interface does not indicate any specific error, but the new tags are not retained when saving the profile.

Steps to Reproduce

Steps to Reproduce:

  1. Log in to your account on biodrop.io.
  2. Navigate to your account settings by selecting your profile icon.
  3. In the account settings, go to "Profile."
  4. Click the "Edit" button next to your profile information.
  5. Scroll down to the "Tags" section.
  6. Begin typing new tags in the provided input field, ensuring to use the correct syntax as requested.
  7. Once you have entered your desired tags, click the "Save Changes" button.

Screenshots

github bug 1 github bug 2

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this

No response

@Abiheb Abiheb added 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 🛠 goal: fix undefined labels Apr 16, 2024
Copy link
Contributor

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
@ChinmayMhatre
Copy link
Member

Issue can be replicated when pressing the enter key. The button doesn't get disabled when using comma .
image
can be an issue with this handler

@ChinmayMhatre ChinmayMhatre added 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Apr 22, 2024
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot unlocked this conversation Apr 22, 2024
@Abiheb
Copy link
Author

Abiheb commented Apr 22, 2024

Do you confirm that im not the only one that has this issue?

@feres7
Copy link

feres7 commented Apr 22, 2024

I tested this issue it happens when adding tags by pressing enter its disabling the save button but works when using comma to add tags as @ChinmayMhatre said also there is another bug related to that handler tags can be duplicated I can work on this and fix both of this bugs could you assign this work to me I will open another issue for the bug related to tags duplication

@MustaphaArfa00
Copy link

I tested this issue and when you add an apostrophe ' to the tag the save button becomes disabled

@feres7
Copy link

feres7 commented Apr 22, 2024

nevermind someone already reported this bug and linked a pull request #10291 #10315

@ChinmayMhatre
Copy link
Member

ChinmayMhatre commented Apr 23, 2024

closing this as duplicate

ℹ️ ChinmayMhatre has some opened assigned issues: 🔧View assigned issues

@ChinmayMhatre ChinmayMhatre closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 goal: fix undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Development

No branches or pull requests

4 participants