Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Another profile page layout #7310

Closed
eddiejaoude opened this issue Jun 1, 2023 · 26 comments
Closed

[FEATURE] Another profile page layout #7310

eddiejaoude opened this issue Jun 1, 2023 · 26 comments
Assignees
Labels
🕹 aspect: interface undefined ⭐ goal: addition undefined 🔢 points: 5 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@eddiejaoude
Copy link
Member

eddiejaoude commented Jun 1, 2023

Description

We currently list links on the profile page and have tabs for events, milestones, testimonials - it would be good to have a 2nd layout option

For example a grid layout of links or possibly 2 columns, links on the left and milestones on the right

We have access to Tailwind paid components we can use https://tailwindui.com/components

This is the file you will probably start working on components/user/UserPage.js

Screenshots

No response

Additional information

No response

@eddiejaoude eddiejaoude added ⭐ goal: addition undefined 🕹 aspect: interface undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) 🔢 points: 5 undefined labels Jun 1, 2023
@niranjank2022
Copy link
Contributor

Hi! I would like to work on this. Please assign me this issue.

@SaraJaoude
Copy link
Member

Hi! I would like to work on this. Please assign me this issue.

@niranjank2022 I will assign this to you

@ChinmayMhatre
Copy link
Member

Could this be done in the docs as well?

@eddiejaoude
Copy link
Member Author

Could this be done in the docs as well?

what do you mean?

@niranjank2022
Copy link
Contributor

Hi! I would like to work on this. Please assign me this issue.

@niranjank2022 I will assign this to you

Thank you!

@niranjank2022
Copy link
Contributor

Description

We currently list links on the profile page and have tabs for events, milestones, testimonials - it would be good to have a 2nd layout option

Maybe grid layout of links or possibly 2 columns, links on the left and milestones on the right

We have access to Tailwind paid components we can use https://tailwindui.com/components

Screenshots

No response

Additional information

No response

I have a doubt. Can you please tell which folder or file I have to work on?

@Dev-Arhaan
Copy link

I think I roughly understand what needs to be done here. But before committing to making code changes, how about we discuss the ui via mockup figma designs or something? @eddiejaoude @SaraJaoude

@eddiejaoude
Copy link
Member Author

I have a doubt. Can you please tell which folder or file I have to work on?

I will update the description

I think I roughly understand what needs to be done here. But before committing to making code changes, how about we discuss the ui via mockup figma designs or something? @eddiejaoude @SaraJaoude

This issue is already assigned

@eddiejaoude
Copy link
Member Author

I have a doubt. Can you please tell which folder or file I have to work on?

I will update the description @niranjank2022

I think I roughly understand what needs to be done here. But before committing to making code changes, how about we discuss the ui via mockup figma designs or something? @eddiejaoude @SaraJaoude

@Dev-Arhaan Mockups are a good idea 👍 btw this issue is already assigned

@Dev-Arhaan
Copy link

How about @niranjank2022 and I collaborate on this project? Should we discuss the mockup ui on discord?

@eddiejaoude
Copy link
Member Author

@Dev-Arhaan I can't decide that, you need to ask @niranjank2022, they might already have some ideas

But we will always add more layouts, so you can come up with a mock up and share it here - if it isn't used on this issue, will be used on another

@niranjank2022
Copy link
Contributor

niranjank2022 commented Jun 3, 2023

How about @niranjank2022 and I collaborate on this project? Should we discuss the mockup ui on discord?

I am open to collaboration. We can surely discuss! @Dev-Arhaan

@niranjank2022
Copy link
Contributor

I'm not able to open User's page in my localhost server? It shows not found? What I need to do?

@eddiejaoude
Copy link
Member Author

I'm not able to open User's page in my localhost server? It shows not found? What I need to do?

From the docs you will need to load the data NOTE: When you have your environment running the database will be empty. You need to visit the path /api/system/reload?secret=development to load the json files https://linkfree.io/docs/environments/local-development

@niranjank2022
Copy link
Contributor

Thanks. It is opening now.

@Dev-Arhaan
Copy link

The mobile UI don't need to change. I think tabs are great for mobile devices.

Or maybe instead of drop down on the mobile, we put two buttons on top with links on left and mile stone on the right.

Beneath these buttons, we can first put all the links and then beneath the links section, we can put the milestones section

What do you think @eddiejaoude

@Dev-Arhaan
Copy link

Something like this roughly

@Dev-Arhaan
Copy link

IMG20230606200949

@eddiejaoude
Copy link
Member Author

Great sketch @Dev-Arhaan it makes it much easier to understand 👍 yes I like making it on a single longer page for mobile without the drop down

@niranjank2022
Copy link
Contributor

A doubt regarding the layout design.
Is this is what you have mentioned that Links to be on left side and Milestones on the right side?
Capture

@niranjank2022
Copy link
Contributor

A doubt regarding the layout design. Is this is what you have mentioned that Links to be on left side and Milestones on the right side? Capture

If this is the case, where would Events and Testimonials come?

@eddiejaoude
Copy link
Member Author

I think they would come below, as another 2 boxes (for desktop), for mobile, they would have be to all under each other in a single column

@Dev-Arhaan
Copy link

I think they would come below, as another 2 boxes (for desktop), for mobile, they would have be to all under each other in a single column

can you expand on this (DeskTop version) a bit more eddie? Also I'm Giving my final end term exams, I will start contributing regularly after this week

@eddiejaoude
Copy link
Member Author

eddiejaoude commented Jun 12, 2023

Desktop will be a 2 column layout, with 2 more boxes below. Good luck in your exams @Dev-Arhaan

@Vishrut19
Copy link
Member

Vishrut19 commented Jun 13, 2023

Hey! Is anyone working on it now? Or I can work on it? Because @Dev-Arhaan has exams that's why I am asking

@SaraJaoude
Copy link
Member

Hey! Is anyone working on it now? Or I can work on it? Because @Dev-Arhaan has exams that's why I am asking

@Vishrut19 as you can see from the comment history there was collaboration only yesterday so this is being worked on. Please also do not make assumptions as to whether assignees have time to work on an issue or not - all this just adds unnecessary notifications and noise. If there is no activity for two weeks then maintainers will look to assign issues to someone else. I am sending you our Contributing Guide once again - I would ask that you read through it as it will help you with contributing to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface undefined ⭐ goal: addition undefined 🔢 points: 5 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Development

No branches or pull requests

6 participants