Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

[BUG] Icon copy notification text is not readable as the underlying elements are also visible. #9618

Closed
1 task done
mrinmay7875 opened this issue Oct 25, 2023 · 13 comments · Fixed by #9726
Closed
1 task done
Assignees
Labels
🛠 goal: fix undefined Hacktoberfest Good issues for Hacktoberfest participants 🔢 points: 2 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@mrinmay7875
Copy link

Has this bug been raised before?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?

production on biodrop.io

Version of BioDrop (for example "v1.2.3")

latest version

Description

In the icons page when we click on the icons then that icons gets copied and we see a toast notification on the right side of the screen. However, the toast notification alert is not solid and hence the underlying elements are not showing visible through the notification and hence the text written in the notification is often not readable properly.

I am attaching a screenshot below.

I think if we can have a solid toast notification that will be better in my opinion.

Screenshots

image

Do you want to work on this issue?

No

If you want to work on this issue...

No response

@mrinmay7875 mrinmay7875 added 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 🛠 goal: fix undefined labels Oct 25, 2023
@github-actions
Copy link
Contributor

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@SaraJaoude
Copy link
Member

We cannot seem to replicate this so I will add the talk: discussion label for now.

One of the things to ascertain is what browser is this appearing in?

@mrinmay7875 please can you edit the description to the version number (saying "latest" can be confusing).

@EddieHubCommunity EddieHubCommunity unlocked this conversation Oct 26, 2023
@mrinmay7875
Copy link
Author

mrinmay7875 commented Oct 26, 2023

@SaraJaoude See that after select on the icon we see this notification where text is not readable properly because the navbar button is showing through the notification.image

Also when we hover over the notification then we see the navbar button is showing up.
image

Regarding the version, I just opened the biodrop.io URL and I can reproduce the issue there.

Regarding the browser, I can reproduce this issue on Chrome and Edge on Mac and Windows as well.

@anirudhp26
Copy link
Contributor

Yes, I am also facing the same issue when I tried replicating it

@anirudhp26
Copy link
Contributor

If this is ready to be fixed then I would like to work on this :)

@mrinmay7875
Copy link
Author

@SaraJaoude Let me know if you are able to reproduce this issue or have any further questions.

@sital002
Copy link
Member

The bug does exist here is the screenshot for it
image

Tested on :
Browser: Mozilla Firefox and Chrome
OS: Ubuntu

@mrinmay7875 If you want to work on the issue please mention that on the issue description since you have already created a PR for it. Please familiarize yourself with our contributing guidelines https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md and don't tag specific maintainers.

@SaraJaoude SaraJaoude added 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) 🔢 points: 2 undefined Hacktoberfest Good issues for Hacktoberfest participants and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 💬 talk: discussion undefined labels Oct 28, 2023
@github-actions
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@SaraJaoude
Copy link
Member

@mrinmay7875 it is unclear as to whether you want to work on this issue or not - but given your comments in your previous PR I am going to assume that you do, so that I will assign this to you.

As Sital mentioned please make it clearer in future if you do want to work on an issue as this avoids confusion for both maintainers and other contributors.

@mrinmay7875
Copy link
Author

mrinmay7875 commented Oct 28, 2023

Thanks for assigning the issue to me, Yes I will work on this issue and create a PR asap

ℹ️ mrinmay7875 has some opened assigned issues: 🔧View assigned issues

@Kamaruddheen
Copy link
Member

Can I take up the issue? As @mrinmay7875 is not having time at the moment and he is okay that I can take up the Issue (#9652 (comment))

@SaraJaoude
Copy link
Member

Can I take up the issue? As @mrinmay7875 is not having time at the moment and he is okay that I can take up the Issue

@Kamaruddheen I have assigned this to you - please also see my comments here: #9652 (comment)

@Kamaruddheen
Copy link
Member

Kamaruddheen commented Nov 4, 2023

@Kamaruddheen I have assigned this to you - please also see my comments here: #9652 (comment)

Got it Sara, Will create new PR and work on it.

ℹ️ Kamaruddheen has some opened assigned issues: 🔧View assigned issues

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛠 goal: fix undefined Hacktoberfest Good issues for Hacktoberfest participants 🔢 points: 2 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
5 participants