Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Mastodon Verfication using rel='me' #9929

Closed
wants to merge 2 commits into from
Closed

fix: Mastodon Verfication using rel='me' #9929

wants to merge 2 commits into from

Conversation

victorchrollo14
Copy link
Contributor

Fixes Issue

Closes #9858

Changes proposed

  • In order to render mastodon link with rel="me" attribute, we have added a rel prop to UserLink component.
  • If a rel prop is passed to the UserLink component, it renders the mastodon link with the rel attribute.
  • In UserLinks component , we check for Maston links, if we find a match then add a rel property to link object
    links.rel = "me" and pass it as a prop to UserLink Component.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

image

Note to reviewers

@github-actions github-actions bot added the issue linked Pull Request has issue linked label Dec 18, 2023
@victorchrollo14
Copy link
Contributor Author

Hey @eddiejaoude. I made this PR a while back.
It has some failing tests because of not having "discernable Text" in the new hidden mastodon link I have added in userLink.js

{rel && (
        <span className="w-0 h-0 absolute left-[-9999px] overflow-hidden ">
          <a  rel={rel}  href={link.url} />
        </span>
      )}

According to : https://dequeuniversity.com/rules/axe/4.8/link-name?application=playwright
Keeping the link hidden is causing this error,

Is there a way to keep the link hidden and not get this error?
Screenshot from 2024-02-24 21-20-31

@victorchrollo14 victorchrollo14 deleted the mastodon-verify branch February 28, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
issue linked Pull Request has issue linked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to include rel="me" tags to links so we van verify our accounts on the fediverse
1 participant
@victorchrollo14