Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

fix: optimized event filtering #9889

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

badrivlog
Copy link
Contributor

@badrivlog badrivlog commented Dec 9, 2023

Fixes Issue

Closes #9877

Changes proposed

  • created a new file filterEvent.js to store re-usable filtering logic
  • added a new state variable eventsToShow and eventsOptions
  • implemented useMemo hook to avoid redundant computations and enhance overall performance

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

proposed changes:
* created a new file `filterEvent.js` to store re-usable filtering logic
* added a new state variable `eventsToShow` and `eventsOptions`
* implemented `useMemo` hook to avoid redundant computations and enhance overall performance
@github-actions github-actions bot added the issue linked Pull Request has issue linked label Dec 9, 2023
@badrivlog badrivlog marked this pull request as ready for review December 12, 2023 12:47
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@eddiejaoude eddiejaoude merged commit b318c05 into EddieHubCommunity:main Jan 12, 2024
13 checks passed
@badrivlog badrivlog deleted the fix-events-filter branch January 12, 2024 12:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue linked Pull Request has issue linked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Inefficient events filtering logic
2 participants