Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

No Space between add link and first link original pr #9822 #9943

Merged
merged 27 commits into from
Jan 12, 2024
Merged

No Space between add link and first link original pr #9822 #9943

merged 27 commits into from
Jan 12, 2024

Conversation

ahmaddonishyar
Copy link
Contributor

@ahmaddonishyar ahmaddonishyar commented Dec 18, 2023 •
edited by eddiejaoude

Fixes Issue

[BUG] No Space between add link and first link

closes #9406

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot 2023-12-18 203821

Note to reviewers

ahmaddonishyar and others added 19 commits November 22, 2023 23:46
@ahmaddonishyar
No Space between add link and first link EddieHubCommunity#9406
b8ab428
@ahmaddonishyar
Merge branch 'main' of github.com:donishyar/BioDrop
7a9af20
@ahmaddonishyar
Merge branch 'main' into main
d3b0316
@ahmaddonishyar
Merge branch 'main' into main
c96f73d
@ahmaddonishyar
user links fixed with better way
a3342e3
@ahmaddonishyar
Merge branch 'main' of github.com:donishyar/BioDrop
6cb3a6c
@ahmaddonishyar
Merge branch 'main' into main
b7eb837
@ahmaddonishyar
Merge branch 'main' into main
70cb1da
@ahmaddonishyar
Merge branch 'main' into main
1d3b82a
@ahmaddonishyar
Merge branch 'main' into main
9997195
@ahmaddonishyar
Merge branch 'main' into main
0ad6928
@ahmaddonishyar
Merge branch 'main' into main
e5b360e
@ahmaddonishyar
Merge branch 'main' into main
ef00c9a
@ahmaddonishyar
Merge branch 'EddieHubCommunity:main' into main
0cfaa7a
@ahmaddonishyar
Merge branch 'main' into main
05e4764
@ahmaddonishyar
Merge branch 'EddieHubCommunity:main' into main
f813b32
@ahmaddonishyar
revert changes
6f27db7
@ahmaddonishyar
margin top added to edit icon and pencil icon size reduced
8205f8c
@ahmaddonishyar
Merge branch 'EddieHubCommunity:main' into main
dbae975
@github-actions github-actions bot added invalid Inappropriate or invalid for Hacktoberfest contributions ✍ chore: profile This label will be added on PR with request of Data json addition labels Dec 18, 2023
@ahmaddonishyar ahmaddonishyar changed the title No Space between add link and first link original pr ##9822 No Space between add link and first link original pr #9822 Dec 18, 2023
kumarsonsoff3
kumarsonsoff3 previously requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @donishyar, I don't think if this issue needs to edit data/tobySolutions/testimonials/loftwah.json file.

Please revert the changes from data/tobySolutions/testimonials/loftwah.json. Let us know if you need any help with this.

@kumarsonsoff3 kumarsonsoff3 added the issue linked Pull Request has issue linked label Dec 18, 2023
@github-actions github-actions bot removed invalid Inappropriate or invalid for Hacktoberfest contributions ✍ chore: profile This label will be added on PR with request of Data json addition labels Dec 19, 2023
@ahmaddonishyar
Copy link
Contributor Author

Hey @donishyar, I don't think if this issue needs to edit data/tobySolutions/testimonials/loftwah.json file.

Please revert the changes from data/tobySolutions/testimonials/loftwah.json. Let us know if you need any help with this.

changes revert

eddiejaoude
eddiejaoude approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@eddiejaoude eddiejaoude merged commit 0bcce23 into EddieHubCommunity:main Jan 12, 2024
13 checks passed
@ahmaddonishyar
Copy link
Contributor Author

Thank you too for letting me to contribute .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eddiejaoude eddiejaoude eddiejaoude approved these changes

@kumarsonsoff3 kumarsonsoff3 Awaiting requested review from kumarsonsoff3

Assignees
No one assigned
Labels
issue linked Pull Request has issue linked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] No Space between add link and first link
3 participants
@ahmaddonishyar @eddiejaoude @kumarsonsoff3