-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample project cards to showcase our projects #24
Sample project cards to showcase our projects #24
Conversation
Looks good 👍 , my feedback:
|
@eddiejaoude ok I will make the changes about the text, and should I keep the image part empty/remove it for now? |
@ritvij14 whatever changes are in the PR, if it is to be merged, it needs to add value to the user/community - I would rather have less "fancy" card but it contained useful information. Put useful in the user's place, if you saw dummy text, that is not useful.
Each project probably has an image, if not, I can create one for you. |
@eddiejaoude I saw images on readme files of EddieBot UI and Eddie Bot map. Others if we want to put, I will need them. |
Looks good 👍 , some of my thoughts
GitHub OrganisationEddieBotAwesome GitHub ProfilesHacktoberfest |
brother, what about cards PR |
@Arvindjitta I was not sure if you were continuing. My bad, I should have tagged you both to work together. Sorry. But multiple types of cards will be needed. Because we will have different sections and it would be good for the cards to be different with 2 styles, in this PR it is vertical and in #21 it is horizontal. Other information that will need cards are:
|
New images to use for the card, these are square GitHub OrganisationDo not add the binary image to git, use this url EddieBot
Website
Awesome GitHub profiles
Support
Hacktoberfest practice
EddieBotMap
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
I have made sample cards for showcasing our projects. These have been made with dummy text and an example png, are responsive and enlarge on hover. Didn't make them too complex for now.
For Issue #1