Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample project cards to showcase our projects #24

Merged
merged 4 commits into from
Aug 27, 2020
Merged

Sample project cards to showcase our projects #24

merged 4 commits into from
Aug 27, 2020

Conversation

ritvij14
Copy link
Member

@ritvij14 ritvij14 commented Aug 26, 2020

I have made sample cards for showcasing our projects. These have been made with dummy text and an example png, are responsive and enlarge on hover. Didn't make them too complex for now.

For Issue #1

image

image

@eddiejaoude
Copy link
Member

Looks good 👍 , my feedback:

  • temporary image is not needed
  • can not be merged with example text, suggest using the existing information from our GitHub Organisation repos

@ritvij14
Copy link
Member Author

@eddiejaoude ok I will make the changes about the text, and should I keep the image part empty/remove it for now?

@eddiejaoude
Copy link
Member

@ritvij14 whatever changes are in the PR, if it is to be merged, it needs to add value to the user/community - I would rather have less "fancy" card but it contained useful information. Put useful in the user's place, if you saw dummy text, that is not useful.

should I keep the image part empty/remove it for now

Each project probably has an image, if not, I can create one for you.

@ritvij14
Copy link
Member Author

@eddiejaoude I saw images on readme files of EddieBot UI and Eddie Bot map. Others if we want to put, I will need them.
And yes you are right, proper info is definitely important. For that, I have replaced dummy info with Project descriptions as were there on the repositories, please tell if they look ok. I put a new image in the PR description above.

@eddiejaoude eddiejaoude changed the base branch from main to develop August 27, 2020 00:03
@eddiejaoude
Copy link
Member

Looks good 👍 , some of my thoughts

  • Don't forget this repo in the list too, add a screenshot of your version of the website when it is done (other projects having their images)
  • I will add some screenshots below, for any that do not have any images, use the screenshot below of the GitHub Organisation

GitHub Organisation

Screenshot 2020-08-27 at 01 07 17

EddieBot

Screenshot 2020-08-27 at 01 06 03

Awesome GitHub Profiles

Screenshot 2020-08-27 at 01 07 30

Hacktoberfest

Screenshot 2020-08-27 at 01 07 46

@Arvindjitta
Copy link
Member

Arvindjitta commented Aug 27, 2020

Looks good 👍 , my feedback:

  • temporary image is not needed
  • can not be merged with example text, suggest using the existing information from our GitHub Organisation repos

brother, what about cards PR adding cards to index.html #21 should i continue it or..?

@eddiejaoude
Copy link
Member

@Arvindjitta I was not sure if you were continuing. My bad, I should have tagged you both to work together. Sorry.

But multiple types of cards will be needed. Because we will have different sections and it would be good for the cards to be different with 2 styles, in this PR it is vertical and in #21 it is horizontal. Other information that will need cards are:

  • Projects
  • Moderators
  • Community members
    and more, so it is not wasted 🤓

@eddiejaoude
Copy link
Member

New images to use for the card, these are square

GitHub Organisation

Do not add the binary image to git, use this url https://user-images.githubusercontent.com/624760/91444606-e687e880-e86c-11ea-9001-522fc212c7c5.png

Screenshot 2020-08-27 at 13 54 09

EddieBot

https://user-images.githubusercontent.com/624760/91444835-3797dc80-e86d-11ea-8dfa-d7993a4d382d.png

Screenshot 2020-08-27 at 13 56 47

Website

https://user-images.githubusercontent.com/624760/91445058-83e31c80-e86d-11ea-8243-3ca11b384d40.png

Screenshot 2020-08-27 at 13 57 51

Awesome GitHub profiles

https://user-images.githubusercontent.com/624760/91445261-cefd2f80-e86d-11ea-8421-4553b29d2e4a.png

Screenshot 2020-08-27 at 13 59 46

Support

https://user-images.githubusercontent.com/624760/91445509-1d123300-e86e-11ea-9648-c5c715355f26.png

Screenshot 2020-08-27 at 14 03 00

Hacktoberfest practice

https://user-images.githubusercontent.com/624760/91445718-61053800-e86e-11ea-81c7-751328c63e85.png

Screenshot 2020-08-27 at 14 00 20

EddieBotMap

https://user-images.githubusercontent.com/624760/91445888-9f9af280-e86e-11ea-8180-9198953bc33d.png

89235454-1e8d6a00-d5e6-11ea-9c65-8f518b6be785

@eddiejaoude eddiejaoude mentioned this pull request Aug 27, 2020
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@eddiejaoude eddiejaoude merged commit 4d542c3 into EddieHubCommunity:develop Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants