Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data: imaaquibali #4961

Merged
merged 4 commits into from Feb 26, 2023
Merged

Conversation

imaaquibali
Copy link
Member

@imaaquibali imaaquibali commented Feb 19, 2023

Changes proposed

Added profile

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Add this profile as soon as possible

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added the large Pull request with more than 30 changed lines label Feb 19, 2023
Copy link
Contributor

@himanshu1221 himanshu1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @imaaquibali please put your file in data folder

@github-actions github-actions bot added ✍ chore: profile This label will be added on PR with request of Data json addition LGTM labels Feb 20, 2023
@imaaquibali
Copy link
Member Author

Hey @imaaquibali please put your file in data folder

Done. Can you please check it know.

himanshu1221
himanshu1221 previously approved these changes Feb 20, 2023
Copy link
Contributor

@himanshu1221 himanshu1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

devvsakib
devvsakib previously approved these changes Feb 20, 2023
Copy link
Member

@devvsakib devvsakib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

Copy link
Member

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

There is a missing , comma. Fix that

data/imaaquibali.json Outdated Show resolved Hide resolved
Co-authored-by: Pradumna Saraf <pradumnasaraf@gmail.com>
@SaraJaoude SaraJaoude dismissed Pradumnasaraf’s stale review February 26, 2023 03:23

I have committed your suggestion

@SaraJaoude
Copy link
Member

looks good

@SaraJaoude SaraJaoude merged commit 1022858 into EddieHubCommunity:main Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✍ chore: profile This label will be added on PR with request of Data json addition large Pull request with more than 30 changed lines LGTM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants