Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI fixes in Search bar #5828

Closed
kumarankit999 opened this issue Apr 4, 2023 · 11 comments · Fixed by #5829
Closed

Update UI fixes in Search bar #5828

kumarankit999 opened this issue Apr 4, 2023 · 11 comments · Fixed by #5829
Labels
⭐ goal: addition undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet)

Comments

@kumarankit999
Copy link
Member

Description

There should be some Margin and Padding between the suggestion notification buttons to the next button ,There should be some gap between them. it looks like the buttons are been touched ,looking not so good the red and white buttons.

Screenshots

linkfree

Additional information

We can do a thing that we increase the margin and padding between them .

@kumarankit999 kumarankit999 added ⭐ goal: addition undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Apr 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@bharathkalyans
Copy link
Contributor

bharathkalyans commented Apr 4, 2023

true, it needs a bit of margin between the tags and I think padding is good enough.

@bharathkalyans
Copy link
Contributor

Added Spacing to the Elements.Below is the snapshot. Please let me know if there are any other changes, else I can PR.
Screenshot 2023-04-04 at 11 24 49 AM

@bharathkalyans
Copy link
Contributor

Fixed the positioning of the Badges as well. The Outcome looks something similar
to the below snapshot.

Screenshot 2023-04-04 at 11 51 55 AM

@kumarankit999
Copy link
Member Author

Now its looking good

@bharathkalyans
Copy link
Contributor

@eddiejaoude Can you please look into this PR.

@eddiejaoude eddiejaoude reopened this Apr 4, 2023
@eddiejaoude
Copy link
Member

I will reopen the issue if the PR is still open

@eddiejaoude
Copy link
Member

This issue is still awaiting triage, and is not ready for development

@eddiejaoude
Copy link
Member

I am only opening an exception this once, please in future please read the project's contributing guide https://github.com/EddieHubCommunity/LinkFree/blob/main/CONTRIBUTING.md

Also note, the maintainers get notified of new issues and pull requests, it is not appropriate to chase 10mins after, especially as we are all in different timezones

@eddiejaoude
Copy link
Member

It is now merged and this issue is closed. Thank you for your contribution, we do have more urgent contributions that would be welcome 👍

@bharathkalyans
Copy link
Contributor

Sure will look into it @eddiejaoude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ goal: addition undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants