CSS changes acc to Issue#948 #1189
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
There was a problem hiding this comment.
Hey! @vish-han, it will be great if you create 2 different Pull requests, for adding your profile and fixing the CSS issue.
For an easy fix, you can remove the profile addition from this PR and raise another one.
If you have any problem in doing that, please ping us :)
There was a problem hiding this comment.
Hi Vishal! I just merged your profile in the other PR you created but unfortunately it has created a conflict in this PR, otherwise the CSS file looks good. If you can solve the merge conflict and let us know when you're done we can take another look at this PR and get it merged. If you need help with the conflict don't hesitate to ask :)
|
@schmelto and @emmalearnscode i have tried to resolve the merge conflict , can you please review the PR now.😊 |
Fixes Issue
#948
Closes #948
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Removed This piece of code from Links.css
https://user-images.githubusercontent.com/57045550/148688461-efae8a09-e7df-41f0-b003-e6fbef402e23.png
Added this code in Links.js
https://user-images.githubusercontent.com/57045550/148688485-54d1f9ae-5859-4b4a-a921-e6ee23871cae.png
Note to reviewers