Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multiple profiles #565

Merged
merged 3 commits into from
Jul 6, 2021
Merged

Conversation

ozansulukpinar
Copy link
Contributor

@ozansulukpinar ozansulukpinar commented Jul 3, 2021

resolve #564
resolve #568
resolve #569
resolve #570
resolve #571
resolve #572
resolve #573
resolve #574
resolve #575
resolve #576
resolve #577

@schmelto
Copy link
Contributor

schmelto commented Jul 4, 2021

I have to take a closer look when I'm home but I think it would be better if there would be an issue for each of those profiles. But this is only my opinion may we can discuss this and someone else can share their thoughts on this.

@ozansulukpinar
Copy link
Contributor Author

I have to take a closer look when I'm home but I think it would be better if there would be an issue for each of those profiles. But this is only my opinion may we can discuss this and someone else can share their thoughts on this.

I revised my issue and pull request like what you suggest. You can check again

data.json Outdated Show resolved Hide resolved
Issue numbers are revised
@ozansulukpinar
Copy link
Contributor Author

It is done.

@schmelto schmelto merged commit 4773144 into EddieHubCommunity:main Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shpatrickguo ThalesBMC leereilly afc163 timburgan
2 participants