Adjust color contrast for github-hover-effect #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can also go for another option, the light tint of grey, let me know what looks good(attached some screenshots for your reference) Dark Mode
Light Mode
|
rahul0x00
changed the title
|
Let's go with darker tone,it matches the other boxes contrast tone |
Cahllagerfeld
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
closes #315
Changes proposed
Adjusted color contrast(changed to darkest shade of gray) of github-hover-effect for both the dark mode as well as for the light mode
Check List (Check all the applicable boxes)
Screenshots
Dark Mode
Light Mode
Note to reviewers