-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding-First commit (ReadMe file) #1962
Comments
Welcome @Stevecmd! Thank you so much for your first issue! Welcome to the community. Also join us in the EddieHub Discord for realtime chat and calls http://discord.eddiehub.org |
Thank you! I did join the discord... |
As for me I am seeing it is fine. Would you mind giving more explanation about how it is slightly different and what has been left out. |
@Stevecmd Greetings! Thank you so much for the issue. As per the issue, could you please specify where exactly you want the change and what are you talking about? It can help if you can maybe provide some more explanation about the same. |
Hi, thanks for reviewing my PR, kindly give me some time to go through it
afresh and get back to you.
Thanks.
…On Tue, Nov 29, 2022, 20:53 Krupali Trivedi ***@***.***> wrote:
@Stevecmd <https://github.com/Stevecmd> Greetings! Thank you so much for
the issue. As per the issue, could you please specify where exactly you
want the change and what are you talking about? It can help if you can
maybe provide some more explanation about the same.
—
Reply to this email directly, view it on GitHub
<#1962 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARLQGM752WCGETVQNOUDTALWKY7IVANCNFSM6AAAAAAQ2M6QTQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Hi, seems I lost my train of thought on the issue, kindly disregard my
Commit. Apologies for the mistake.
…On Tue, Nov 29, 2022, 20:57 Steve Murimi ***@***.***> wrote:
Hi, thanks for reviewing my PR, kindly give me some time to go through it
afresh and get back to you.
Thanks.
On Tue, Nov 29, 2022, 20:53 Krupali Trivedi ***@***.***>
wrote:
> @Stevecmd <https://github.com/Stevecmd> Greetings! Thank you so much for
> the issue. As per the issue, could you please specify where exactly you
> want the change and what are you talking about? It can help if you can
> maybe provide some more explanation about the same.
>
> —
> Reply to this email directly, view it on GitHub
> <#1962 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ARLQGM752WCGETVQNOUDTALWKY7IVANCNFSM6AAAAAAQ2M6QTQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***
> com>
>
|
@Stevecmd Do not worry about it at all! It is nothing to apologize for! We are grateful that you could find or can possibly suggest some enhancements for the project! Do let us know if you need any helP! |
Allright, thanks!
…On Tue, Nov 29, 2022, 21:03 Krupali Trivedi ***@***.***> wrote:
@Stevecmd <https://github.com/Stevecmd> Do not worry about it at all! It
is nothing to apologize for! We are grateful that you could find or can
possibly suggest some enhancements for the project! Do let us know if you
need any helP!
—
Reply to this email directly, view it on GitHub
<#1962 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARLQGM55ASESMGCGBK32SYDWKZAQ3ANCNFSM6AAAAAAQ2M6QTQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
I also think existing documentation is clear to understand, we don't require any changes, and may close this issue. |
Welcome @Stevecmd! Thank you so much for your first issue! Welcome to the community. Also join us in the EddieHub Discord for realtime chat and calls http://discord.eddiehub.org |
Description
The steps to fork the GitHub repo and make the first commit may need a review as the steps particularly after editing the ReadMe may need to be updated. The pull request procedure is slightly different from that described in the instructions.
Screenshots
No response
Additional information
Its mostly a convenience bug, for those who perform the pull request online.
The text was updated successfully, but these errors were encountered: