Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding-First commit (ReadMe file) #1962

Closed
Stevecmd opened this issue Oct 1, 2022 · 11 comments
Closed

Onboarding-First commit (ReadMe file) #1962

Stevecmd opened this issue Oct 1, 2022 · 11 comments
Labels
bug Something isn't working

Comments

@Stevecmd
Copy link

Stevecmd commented Oct 1, 2022

Description

The steps to fork the GitHub repo and make the first commit may need a review as the steps particularly after editing the ReadMe may need to be updated. The pull request procedure is slightly different from that described in the instructions.

Screenshots

No response

Additional information

Its mostly a convenience bug, for those who perform the pull request online.

@Stevecmd Stevecmd added the bug Something isn't working label Oct 1, 2022
@github-actions
Copy link

github-actions bot commented Oct 1, 2022

Welcome @Stevecmd! Thank you so much for your first issue! Welcome to the community. Also join us in the EddieHub Discord for realtime chat and calls http://discord.eddiehub.org

@Stevecmd
Copy link
Author

Stevecmd commented Oct 4, 2022

Welcome @Stevecmd! Thank you so much for your first issue! Welcome to the community. Also join us in the EddieHub Discord for realtime chat and calls http://discord.eddiehub.org

Thank you! I did join the discord...

@yrncollo
Copy link
Contributor

As for me I am seeing it is fine. Would you mind giving more explanation about how it is slightly different and what has been left out.

@krupalitrivedi
Copy link
Member

@Stevecmd Greetings! Thank you so much for the issue. As per the issue, could you please specify where exactly you want the change and what are you talking about? It can help if you can maybe provide some more explanation about the same.

@Stevecmd
Copy link
Author

Stevecmd commented Nov 29, 2022 via email

@Stevecmd
Copy link
Author

Stevecmd commented Nov 29, 2022 via email

@krupalitrivedi
Copy link
Member

@Stevecmd Do not worry about it at all! It is nothing to apologize for! We are grateful that you could find or can possibly suggest some enhancements for the project! Do let us know if you need any helP!

@Stevecmd
Copy link
Author

Stevecmd commented Nov 29, 2022 via email

@kulkarniyash7
Copy link
Member

I also think existing documentation is clear to understand, we don't require any changes, and may close this issue.

@github-actions
Copy link

Welcome @Stevecmd! Thank you so much for your first issue! Welcome to the community. Also join us in the EddieHub Discord for realtime chat and calls http://discord.eddiehub.org

@schmelto
Copy link
Contributor

schmelto commented Jul 9, 2023

-> #1962 (comment)

@schmelto schmelto closed this as completed Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants