Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help me to fix link #277

Closed
longqua69 opened this issue Feb 20, 2021 · 7 comments
Closed

Help me to fix link #277

longqua69 opened this issue Feb 20, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@longqua69
Copy link
Contributor

Hello,

I made a PR and I figured this link is dead.

When I click on this link, it point to https://github.com/EddieJaoudeCommunity instead of https://github.com/EddieHubCommunity

At present, I don't know how to fix it? how it operates? ...? My web development knowledge is limited now and I'm working on it. So I raise an issue. Would you please fix the link or let me know how to fix.

Thanks

Deadlink

@github-actions
Copy link

It's great having you contribute to this project

Feel free to raise an Issue! Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@adityaraute
Copy link
Member

adityaraute commented Feb 24, 2021

Great spot! You need to go to the action that is triggered whenever an Issue or PR is created. In that action spot the message, and the link will be there. Let me know if you need anything else.

@eddiejaoude
Copy link
Member

Thank you for raising this issue 👍

I think this link has been fixed in the gh-action-community repo where most of the Action code exists. I did not deploy it yet, let me deploy it now.

But there are also other things that need updating too... it is possible to search our Org repos for EddieJaoudeCommunity, for example on this repo https://github.com/EddieHubCommunity/hacktoberfest-practice/search?q=EddieJaoudeCommunity

@eddiejaoude
Copy link
Member

I deployed the code, let's create a new test issue and see if it works 🤓 EddieHubCommunity/gh-action-community#71

eddiejaoude added a commit that referenced this issue Feb 24, 2021
@eddiejaoude
Copy link
Member

I think I fixed it #284. Feel free to raise a test issue and check.

But this will now need fixing in all our Org repos, here are the changes I made to use the updated Action https://github.com/EddieHubCommunity/hacktoberfest-practice/blob/main/.github/workflows/community.yml

Any questions let me know.

@longqua69
Copy link
Contributor Author

Hi @adityaraute, Thanks for your instruction. Now, I know how it works. Let me explore more about it.

Hi @eddiejaoude, Thanks for helping me to fix this issue.

I think this kind of issue occurs when we rename the repository. I think there are 2 ways to prevent such kind of issue:

_ The first one: I've not known if there's any feature to make the referenced link change automatically (just like to refer to a variable in any programming language). I watched the video Eddie talks about how to change the URL of origin so I think we can change the URL manually only.

_ The second one: I'll explore to make a script to count all refer URL we need to check for preventing this issue like this. If you know any, please let me know.

Thanks

@eddiejaoude
Copy link
Member

This type of change does not usually happen, so I think it is not worth worrying too much about.

Another alternative would have been to use sub domains that redirect as these would change, for example we have

  • discord.eddiehub.org
  • github.eddiehub.org
    ...

I will close this issue for now. Thanks again for highlighting this issue 👍

@eddiejaoude eddiejaoude added the bug Something isn't working label Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants