Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot share multiple images #121

Closed
marcsyp opened this issue May 21, 2014 · 8 comments
Closed

Cannot share multiple images #121

marcsyp opened this issue May 21, 2014 · 8 comments

Comments

@marcsyp
Copy link

marcsyp commented May 21, 2014

Would be fantastic to be able to pass an array of file locations to the share functions and have them all show up in a single facebook post or email, for instance. Thanks.

@EddyVerbruggen
Copy link
Owner

Hi,

It is now possible to use the shareViaEmail function to share multiple images.

Adding this feature to the other functions is under consideration.

Thanks,
Eddy

@marcsyp
Copy link
Author

marcsyp commented May 28, 2014

Fantastic. Will try out the new email functionality. Would absolutely love
to see this added to the other functions... Other folks interested?
On May 26, 2014 7:58 AM, "Eddy Verbruggen" notifications@github.com wrote:

Hi,

It is now possible to use the shareViaEmail function to share multiple
images.

Adding this feature to the other functions is under consideration.

Thanks,
Eddy


Reply to this email directly or view it on GitHubhttps://github.com//issues/121#issuecomment-44196119
.

@EddyVerbruggen
Copy link
Owner

I'm working on multi-file support for other functions. Android is almost done. I hope to find some time to implement and test iOS during the next couple of days.

@marcsyp
Copy link
Author

marcsyp commented May 30, 2014

Yes!! This is super awesome. Is there any way for me to test the latest
version with Android functionality? I'm not building for iOS at the moment
and would love to get this in ASAP. Otherwise, np, I can wait. :)

Thanks,
Marc

On Fri, May 30, 2014 at 8:09 AM, Eddy Verbruggen notifications@github.com
wrote:

I'm working on multi-file support for other functions. Android is almost
done. I hope to find some time to implement and test iOS during the next
couple of days.


Reply to this email directly or view it on GitHub
#121 (comment)
.

Marc Syp, Application Engineer
San Francisco, CA

WARNING: The information contained in this message is legally
privileged and proprietary information intended only for the use of
the individual or entity named above. If the reader of this message is
not the intended recipient, you are hereby notified that any
dissemination, distribution, or copy of this message is strictly
prohibited. If you have received this message in error, please
immediately delete the original message and notify the sender.
Communication of the information contained in this message to any
unauthorized persons may be a violation of state or federal laws.

@EddyVerbruggen
Copy link
Owner

@marcsyp drop me an email at eddyverbruggen[at]gmail.com and I sent you the new js and java files if you like.

@EddyVerbruggen
Copy link
Owner

aaaaand it's done. Please test a bit guys. I've done my very best to not break any current usage.

The details are in the readme

@marcsyp
Copy link
Author

marcsyp commented May 31, 2014

Super awesome. I got out of bed and installed it right away.

Good news:
shareViaFacebook works splendidly
share also works great (tested with SMS/MMS, G+, Drive, email, facebook)

Bad news:
shareViaTwitter not working with array argument (still works for single url)
// just found the explicit statement in the readme about twitter and multiple files. perhaps a note could also be included in the shareViaTwitter usage section of the readme, just for coverage...

Anyway... this is awesome! Thanks so much for adding this, it is a huge win for my app. :)

@EddyVerbruggen
Copy link
Owner

Hi, glad you like it and thx for testing.

There is a note about Twitter in the 'sharing multiple images' section but you're right, I'll add it to shareViaTwitter as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants