Run sharing in main thread

[TdoubleG]

In Xcode you will see an error that the ActivityController should run in main thread

[murcie]

Same issue. I think should be merged.

[reports] Main Thread Checker: UI API called on a background thread: -[UIViewController setValue:forKey:]
PID: 56663, TID: 4051744, Thread name: (none), Queue name: com.apple.root.default-qos, QoS: 0
Backtrace:
4   ProjectName                         0x000000010494f8c8 __61-[SocialSharing shareInternal:withOptions:isBooleanResponse:]_block_invoke + 2276

[koraysels]

could this be the cause of the long initial load time of the share menu?

[TdoubleG]

Yes

[koraysels]

cool man, ill just use your branch in my app :D

[santiq]

Instead of deleting the line, this should be a configuration option

[EddyVerbruggen]

Everybody, please promise me nobody is going to open an issue that Cordova is yelling in the console that this method is taking too long and should not run in the main thread.

[TdoubleG]

@santiq it doesn’t make sense to set the line as configuration because it’s an error from the iOS System. You can find it also in the documentation from Apple