fix: childViewController removed correctly on hide

When 'hidden' is specified for a tab, it gets added as a childView to the viewController, but did not get removed again on hide().
EddyVerbruggen · Mar 6, 2018 · a0c7233 · a0c7233
1 parent 0fd08fd
commit a0c7233
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/ios/SafariViewController.m b/src/ios/SafariViewController.m
@@ -109,6 +109,14 @@ - (UIColor *)colorFromHexString:(NSString *)hexString {
 }
 
 - (void) hide:(CDVInvokedUrlCommand*)command {
+  SFSafariViewController *childVc = [self.viewController.childViewControllers lastObject];
+  if (childVc != nil) {
+    [childVc willMoveToParentViewController:nil];
+    [childVc.view removeFromSuperview];
+    [childVc removeFromParentViewController];
+    childVc = nil;
+  }
+
   if (vc != nil) {
     [vc dismissViewControllerAnimated:self.animated completion:nil];
     vc = nil;