Use flag PackageManager.MATCH_ALL to search all Android browsers #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of just default
|
Looks legit, thx! |
|
@EddyVerbruggen thanks for merging so quickly! If you have any time today, releasing a new version/point release with this fix would be hugely appreciated. |
|
Available from npm in version 1.4.7 now 💥 |
|
Awesome :)
Thank you so much!
…On Mar 23, 2017, 1:28 PM -0500, Eddy Verbruggen ***@***.***>, wrote:
Available from npm in version 1.4.7 now 💥
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #58.
The existing implementation only queries for the default browser when pulling app candidates with the ACTION_VIEW intent. For example, if Samsung's "Internet" browser application (running Chromium 44) is set as default, even with Chrome installed, isAvailable() will return false. This change more closely aligns with the comment on line 75