Post Install Concept #101
Post Install Concept #101
Conversation
| if (err) { | ||
| return console.log(err); | ||
| } | ||
| if (result.using_android && result.using_android.toLowerCase() === 'y') { |
There was a problem hiding this comment.
You could use the isSelected convenience function here as well.
|
Man, I totally love it! ❤️ I only have a few trivial remarks but without those I think it's already good enough to merge, so your call if you want to add anything before I merge it.
Btw, please don't remove the Podfile and include.gradle files for now (which you haven't, so that's cool) because I'm quite sure it will break builds for Telerik Platform users. I can live with the duplicate maintenance for now. Also, seeing this work so well do you think it would be possible to automate adding those 2 lines to the I will grant you commit access so you can work in this repo directly if you please (fi. for hotfixes to the script, if required). |
|
This is Amazing! |
|
@EddyVerbruggen Thanks for the great feedback! I'll be digging into your suggested improvements now 👍 |
…or Facebook & Google
|
@EddyVerbruggen The suggested improvements have been implemented. This branch should be ready to merge. Thanks!! |
|
I'm so excited about this 👯 👯 👯 👯 👯 |
| } | ||
|
|
||
| repositories { | ||
| mavenCentral() |
There was a problem hiding this comment.
With how gradle works, gradle selects the first repository that contains the required dependency and uses that. per this release Android Studio migrated their default repository to jcenter.
jcenter is a superset of mavenCentral with the added bonus of serving their content over HTTPS and a CDN!
My recommendation would be to place jcenter first so at least the repositories will default to this preference. The more extreme being that since it's a superset, removing mavenCentral shouldn't have any issues.
|
Great, Great work! I'll merge this tomorrow, so if anyone want to add (more) comments go right ahead. @sean-perkins The README and the files in /docs will need adjustment but I'll be more than happy to do that myself after this is merged. @white0ut, also thanks for your suggestion, I'll be keeping that in mind. |
|
Hey @sean-perkins do you agree we can remove the 'application package' step since NativeScript added it (recently) by default to in 2.1.0. It gets written to I'll also remove that manual step from the readme and urge users to use 2.1.0+. |
|
@sean-perkins great job. I was in the process of doing something similar. Thank god I ended up here. @EddyVerbruggen when do you think it will be merged? |
|
@vekexasia today |
|
@EddyVerbruggen That sounds like a great plan to promote the later builds. I will commit the removal in a second. |
|
Merged! 🎉 I'll tweak the docs where needed. |
- trivial cleanup - doc adjustments - version bump
|
@EddyVerbruggen is this documented? @sean can we make a lovely NativeScriptSnack of your video? wonderful work! |
|
Yes it is |
|
@jlooper Do you want a write-up of the process and concept of post-install or specifically the firebase post-install process for this plugin? |
|
@sean I was just thinking that a video of the exact process of the post-install process for this plugin would be really good to include on the snacks site. In terms of docs, I was looking for it on the homepage of the readme but maybe missed it. |
- trivial cleanup - doc adjustments - version bump
Current Situation:
In a multi-developer environment, each developer has to manually configure their
Podfileandinclude.gradlefile to include any of the add-on micro-services that firebase offers. This isn't ideal, because often times users are not aware of these steps when being added to an existing project.Proposed Solution:
This pull-request contains a post-install script that will run after every installation of the firebase plugin. It prompts the user if they are using iOS and/or Android and then walks the user through the available micro-services. Once the prompts complete, the script will overwrite the
Podfileandinclude.gradlefile with the base dependencies, as well as the selected micro-services. Items that they prompted "n" (no) for, will be commented out as they were previously.I'm open feedback and/or changes. I just ran into this issue with my own plugins and found that this was an effective solution for my team environment.
Concept: