This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Mark init and getRemoteConfig for profiling #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These sometimes complete async or are called in the application launched event and the times spend inside are otherwise hard to track. Wrapping these in profile will show them when running the timeline profiling. init on my android phone spends about 150ms, that's fine but I'd like to be able to keep an eye on it. I did the changes in the GitHub UI, so please test it before merge.
|
Thanks! Is there a chance (with a lower {N} version) that |
|
Yes. This is relatively new feature. |
|
OK thanks, I will make sure it'll work with older versions as well. |
|
4.0.6 contains a backward compatible version of this PR. Now available on npm. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These sometimes complete async or are called in the application launched event and the times spend inside are otherwise hard to track. Wrapping these in profile will show them when running the timeline profiling. init on my android phone spends about 150ms, that's fine but I'd like to be able to keep an eye on it.
I did the changes in the GitHub UI, so please test it before merge.