Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Mark init and getRemoteConfig for profiling #449

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

PanayotCankov
Copy link
Contributor

These sometimes complete async or are called in the application launched event and the times spend inside are otherwise hard to track. Wrapping these in profile will show them when running the timeline profiling. init on my android phone spends about 150ms, that's fine but I'd like to be able to keep an eye on it.

I did the changes in the GitHub UI, so please test it before merge.

These sometimes complete async or are called in the application launched event and the times spend inside are otherwise hard to track. Wrapping these in profile will show them when running the timeline profiling. init on my android phone spends about 150ms, that's fine but I'd like to be able to keep an eye on it.

I did the changes in the GitHub UI, so please test it before merge.
@EddyVerbruggen
Copy link
Owner

Thanks! Is there a chance (with a lower {N} version) that require("profiling").profile resolves to nothing?

@PanayotCankov
Copy link
Contributor Author

Yes. This is relatively new feature.

@EddyVerbruggen
Copy link
Owner

OK thanks, I will make sure it'll work with older versions as well.

@EddyVerbruggen EddyVerbruggen merged commit 53e9f4c into EddyVerbruggen:master Aug 23, 2017
@EddyVerbruggen EddyVerbruggen added this to the 4.0.6 milestone Aug 23, 2017
@EddyVerbruggen
Copy link
Owner

4.0.6 contains a backward compatible version of this PR. Now available on npm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants