Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/palette spelling #110

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Fix/palette spelling #110

merged 2 commits into from
Mar 31, 2022

Conversation

EdenEast
Copy link
Owner

@EdenEast EdenEast commented Mar 31, 2022

I cant spell... pallet is also a word and spell check did not save me. Oh well here is a large pr to fix it. Sorry everyone for the deprecation.

BREAKING CHANGE: Renamed pallet to correct spelling palette

Fixes: #106

I was using `pallet` which is the thing you use for shipping... What I
wanted was a `palette` of color... Sorry everyone spellcheck did not
save me here :P
@EdenEast EdenEast added bug Something isn't working documentation Improvements or additions to documentation breaking A change that introduces a breaking change for users labels Mar 31, 2022
@EdenEast EdenEast self-assigned this Mar 31, 2022
@EdenEast EdenEast merged commit 24c9fe1 into main Mar 31, 2022
@EdenEast EdenEast deleted the fix/palette-spelling branch March 31, 2022 01:27
@pmrt
Copy link

pmrt commented Jun 8, 2022

Please, @EdenEast make a pinned issue with all the breaking changes listed and do not suddenly remove old APIs, but add a warning (with vim.notify or something like that) with a deprecated notice like other plugins do. I just spent 1 hour or more figuring out this issue.

Anyway, thanks for your work on this theme, it's awesome.

@EdenEast
Copy link
Owner Author

EdenEast commented Jun 9, 2022

There is a check that prints a deprecation warning on first load here. Did this not show up for you?

@pmrt
Copy link

pmrt commented Jun 9, 2022

Oh, I definitely must have missed that! May I suggest to use vim.notify like nvim-tree and LSP?

https://github.com/neovim/neovim/blob/c5720c72213810adb75d3277ac645eb6fc8dafa8/runtime/lua/vim/lsp.lua#L1092-L1098

It is more visible than nvim_echo and more appropriate for this use case IMO. Also, I love when plugins provide a pinned issue with breaking changes: hrsh7th/nvim-cmp#231 because that way people can subscribe to them.

Btw, this is a different issue but speaking of spelling, I think it is deprecation not deprication:) - https://github.com/EdenEast/nightfox.nvim/blob/63a8eb6/lua/nightfox/util/deprication.lua

Sorry for the off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A change that introduces a breaking change for users bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spelling: "palette"
2 participants