Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bufferline support #114

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Add bufferline support #114

merged 1 commit into from
Apr 4, 2022

Conversation

mehalter
Copy link
Contributor

@mehalter mehalter commented Apr 4, 2022

I have been using bufferline recently and wanted to provide a default theme that can be easily used with it. Here is a screenshot as well:
2022-04-04_10:36:36_screenshot

@mehalter
Copy link
Contributor Author

mehalter commented Apr 4, 2022

Hm looks like my PR has a stylua issue in ./lua/nightfox/util/template.lua. I am not modifying this file in this PR. Should I go ahead and fix the stylua issue?

@EdenEast
Copy link
Owner

EdenEast commented Apr 4, 2022

It looks like stylua released a new version 4 days ago with a new version 0.13.0 which fixed some issues that were in the repo. I have updated the files in question. Everything looks good the only thing I would say is check for the tabs in the first section of lua/nightfox/group/modules/bufferline.lua. Once that is done we can get that merged.

@EdenEast EdenEast self-assigned this Apr 4, 2022
@EdenEast EdenEast added enhancement New feature or request module Relates to modules/plugins labels Apr 4, 2022
Signed-off-by: Micah Halter <micah@balena.io>
@mehalter
Copy link
Contributor Author

mehalter commented Apr 4, 2022

Ah nice catch, I forgot stylua is disabled for that section. I updated my commit to fix this

@EdenEast
Copy link
Owner

EdenEast commented Apr 4, 2022

Ya I was doing that because I found that easier to read when I aligned the sections to read what the fg and bg are.

@EdenEast
Copy link
Owner

EdenEast commented Apr 4, 2022

LGTM

@EdenEast EdenEast merged commit 5bdb32b into EdenEast:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module Relates to modules/plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants