Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groups option per style #154

Merged
merged 1 commit into from
May 10, 2022
Merged

groups option per style #154

merged 1 commit into from
May 10, 2022

Conversation

EdenEast
Copy link
Owner

palette and spec can both be overridden per style but group was not. This change makes all override tables work the same.

Old

require("nightfox").setup({
  groups = {
    CursorColumn = { bg = "sel0", link = "" },
    IncSearch = { bg = "palette.cyan" },
  },
})

New

require("nightfox").setup({
  groups = {
    all = {
      CursorColumn = { bg = "sel0", link = "" },
      IncSearch = { bg = "palette.cyan" },
    },
  },
})

@EdenEast EdenEast added enhancement New feature or request breaking A change that introduces a breaking change for users labels May 10, 2022
@EdenEast EdenEast self-assigned this May 10, 2022
BREAKING CHANGE: `groups` options now takes options per style + `all`
@AnthonyK213
Copy link

AnthonyK213 commented May 10, 2022

Nice work! But it seems that all is not included in foxes, which causes though using all in groups, the warning "The following has bee Deprecated ... for every style" still appears on the start of nvim.

if not collect.contains(foxes, key) then

@EdenEast
Copy link
Owner Author

Yes thanks for the catch fixing.

@EdenEast
Copy link
Owner Author

This should be fixed with commit 63a8eb6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A change that introduces a breaking change for users enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants