refactor: Configuration moved to lua #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the way that nightfox is configured. When create the example of overriding highlight groups there was an ordering of configuration steps that was highlighted. This change converts the global variables that used to configure nightfox into a lua setup function. The loading of this configuration and applying the colorscheme is in a seperate load function. This change also documents this in the readme. The old global variable configuration is checked for and deprication warning are shown. BREAKING CHANGE
EdenEast
added
documentation
EdenEast
force-pushed
the
refactor/lua-config
branch
from
0902a34
to
4fcae25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr outlines changes made to move configuration from global variables to lua setup and load functions. This change deprecates the old global variables in favor of the lua
setupfunction. Nightfox prints a warning to the user about the depreciation.An issue will be pinned about the deprecation.
New configuration looks like this:
Fixes #19