Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip not fully rendered when out of radar bounds #1

Open
EdgarsGarsneks opened this issue Dec 4, 2023 · 0 comments
Open

Tooltip not fully rendered when out of radar bounds #1

EdgarsGarsneks opened this issue Dec 4, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@EdgarsGarsneks
Copy link
Owner

EdgarsGarsneks commented Dec 4, 2023

Description

Tooltip text being cut when near right margin making text unreadable.

Bug

Expected Behavior

When text cannot fully fit the screen, it's position should be adjusted to fit (if possible, not talking about unreasonable text lengths).

How To Reproduce?

This issue can be reproduced with following config

{
    "width": 300,
    "style": { "seed": 34 },
    "sectors": [
        { "label": "Sector 1"},
        { "label": "Sector 2"},        
        { "label": "Sector 2"}
    ],
    "rings": [
        { "label": "Ring1",  "color": "green" },
        { "label": "Ring2",  "color": "green" }    
    ],
    "entries": [ { "label": "My Longer Text", "sector": 0, "ring": 1, "moved": 0 } ]
}

Solution Proposal

In the RadarRenderer.ts in showTooltip method include necessary position update in "transform" attribute.

@EdgarsGarsneks EdgarsGarsneks added bug Something isn't working good first issue Good for newcomers labels Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant