William/rn64 #2552
Merged
William/rn64 #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
force-pushed
the
william/rn64
branch
from
89e01b1
to
19ca133
Compare
paullinator
reviewed
Apr 22, 2021
| def versionCodes = ["armeabi-v7a": 1, "x86": 2, "arm64-v8a": 3, "x86_64": 4] | ||
| def abi = output.getFilter(OutputFile.ABI) | ||
| if (abi != null) { // null for the universal-debug, universal-release variants | ||
| output.versionCodeOverride = | ||
| versionCodes.get(abi) * 1048576 + defaultConfig.versionCode | ||
| defaultConfig.versionCode * 1000 + versionCodes.get(abi) |
There was a problem hiding this comment.
Very bizarre change. Any reference on why?
There was a problem hiding this comment.
There was a problem hiding this comment.
paullinator
reviewed
Apr 22, 2021
thehobbit85
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS feels weirdly faster with this change, but it could be my imagination.
PR Requirements
If you have made any visual changes to the GUI. Make sure you have: