Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small corrections to DA #70

Merged
merged 2 commits into from
Feb 17, 2024
Merged

small corrections to DA #70

merged 2 commits into from
Feb 17, 2024

Conversation

HThuren
Copy link
Contributor

@HThuren HThuren commented Feb 13, 2024

? where to find 'dansk' in language selector at web, have to be 'Dansk'

and Bump iso-639-1 from 2.1.11 to 3.1.1

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99d2c90) 51.18% compared to head (f24ec2a) 51.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   51.18%   51.18%           
=======================================
  Files          89       89           
  Lines        9015     9015           
  Branches      685      685           
=======================================
  Hits         4614     4614           
  Misses       4392     4392           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@freshollie
Copy link
Collaborator

The language names come from this package: https://github.com/meikidd/iso-639-1/blob/master/src/data.js#L122

If it should be captalized in the native language you could submit a PR there and update the library here :)

@HThuren
Copy link
Contributor Author

HThuren commented Feb 15, 2024

The language names come from this package: https://github.com/meikidd/iso-639-1/blob/master/src/data.js#L122

If it should be captalized in the native language you could submit a PR there and update the library here :)

Thank you, I have maked a PR for the correction :-)

@HThuren
Copy link
Contributor Author

HThuren commented Feb 16, 2024

@freshollie ... and the PR are merged by meikidd :-)

@HThuren
Copy link
Contributor Author

HThuren commented Feb 16, 2024

@freshollie package.json are reported not to be part of git, can you fix that ?
image

@HThuren
Copy link
Contributor Author

HThuren commented Feb 17, 2024

@freshollie anyway, please approved this PR, have some small correction to #69

@freshollie
Copy link
Collaborator

If you commit with -n you can ignore the error. Please include the library upgrade as part of this

@HThuren
Copy link
Contributor Author

HThuren commented Feb 17, 2024

If you commit with -n you can ignore the error. Please include the library upgrade as part of this

YES ! thank you :-)

@HThuren
Copy link
Contributor Author

HThuren commented Feb 17, 2024

(sorry mixed different branch when make another PR)
Now ready here both DA correction and Bump of iso639-1

@freshollie freshollie merged commit 945382d into EdgeTX:main Feb 17, 2024
16 of 17 checks passed
@HThuren HThuren deleted the correctDA branch February 17, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants