-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small corrections to DA #70
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
=======================================
Coverage 51.18% 51.18%
=======================================
Files 89 89
Lines 9015 9015
Branches 685 685
=======================================
Hits 4614 4614
Misses 4392 4392
Partials 9 9 ☔ View full report in Codecov by Sentry. |
The language names come from this package: https://github.com/meikidd/iso-639-1/blob/master/src/data.js#L122 If it should be captalized in the native language you could submit a PR there and update the library here :) |
Thank you, I have maked a PR for the correction :-) |
@freshollie ... and the PR are merged by meikidd :-) |
@freshollie package.json are reported not to be part of git, can you fix that ? |
@freshollie anyway, please approved this PR, have some small correction to #69 |
If you commit with -n you can ignore the error. Please include the library upgrade as part of this |
YES ! thank you :-) |
(sorry mixed different branch when make another PR) |
? where to find 'dansk' in language selector at web, have to be 'Dansk'
and Bump iso-639-1 from 2.1.11 to 3.1.1