SD Log interval changes in global / special functions are not saved

[ParkerEde]

Is there an existing issue for this problem?

• I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

With the 2.9.0 RC1 it is currently no longer possible to change the LOG interval time from e.g. 1.0s to 0.5s in the global functions, as this is not saved. At first everything is displayed correctly, but when you leave the system menu and open it again, then open the global functions, the value is back to the initial value after you have gone back into editing.

Expected Behavior

the value should be saved

Steps To Reproduce

1. open SYS
2. open GF
3. change intervall value for SD-LOG
4. close GF
5. close SYS
6. open SYS
7. open GF
8. edit entry for SD-LOG
9. observ the value is not saved

Version

Other (Please specify below)

Transmitter

FrSky X10 Express / X10S Express (ACCESS)

Operating System (OS)

No response

OS Version

No response

Anything else?

2.9.0 RC1

[pfeerick]

Happens for both special functions and global functions for me on TX16S

Closing radio menu is not necessary to repo... simply create / edit interval, close the edit screen, observe the just entered value on the overview, re-edit, and it will reset back to 1.0s

[pfeerick]

Most likely caused by #3058 as I think

edgetx/radio/src/gui/colorlcd/special_functions.cpp

Line 235 in 8f0ad3f

CFN_PARAM(cfn) = SD_LOGS_PERIOD_DEFAULT; // set default value

obliterates the current value every time the dialog is opened 🤭 . In other words, the value is saved every time you edit it, but is reset back to 1.0 if you re-enter the edit screen.