Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SD Logs interval shown as default value when entering SF edit window #3755

Merged
merged 1 commit into from Jul 4, 2023
Merged

fix: SD Logs interval shown as default value when entering SF edit window #3755

merged 1 commit into from Jul 4, 2023

Conversation

mha1
Copy link
Contributor

@mha1 mha1 commented Jul 3, 2023

fixes #3751

changes:

  • use stored value if SF exists otherwise initialize with default value

@mha1
fixes EdgeTX#3751
69c7fb5 
changes:
- set default value only if SF is created
@pfeerick pfeerick added color Related generally to color LCD radios bug/regression ↩️ A new version of EdgeTX broke something labels Jul 3, 2023
@pfeerick pfeerick added this to the 2.9 milestone Jul 3, 2023
@pfeerick pfeerick merged commit d9b9530 into EdgeTX:main Jul 4, 2023
34 checks passed
pfeerick pushed a commit that referenced this pull request Jul 4, 2023
@mha1 @pfeerick
fix: Don't override configured SD Logs value when opening edit screen (…
d214962 
…#3755)

changes:
- set default value only if SF is created
@ParkerEde
Copy link
Contributor

great. Now it's okay. Thx

@mha1 mha1 deleted the fix__#3751_SD_logs_rate_goes_back_to_default_value branch July 6, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug/regression ↩️ A new version of EdgeTX broke something color Related generally to color LCD radios
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

SD Log interval changes in global / special functions are not saved
3 participants
@mha1 @ParkerEde @pfeerick