TPro - Port of OpenTX function switches management

[Batambatam]

Summary of changes:
Port of opentx/opentx#8847
Credits go to @elecpower and @3djc who did all the work for OpenTX.

Function switches of Jumper T-Pro can be setup and used in inputs, mixes, etc. and saved / loaded.

[pfeerick]

My initial tests on TPro with this seem to have a few hiccups still...

1. inactive and active are reversed - most noticeable if you have all but one switches inactive and then all but one them light up in your face at boot 😆 Actually, I'll retract that for now... I haven't been able to get it to happen a second time, so I won't rule out me stupidly setting it inverted myself...

2. saving of name (and reading back from) yaml mangled... i.e.

functionSwitchNames:
  0: SL
  1: HOR
  2: AIR
  3: RTH
  4: PH
  5: BP

should be

switchNames: 
   0:
      val: "SL"
   1:
      val: "HOR"

Other than that, this seems to be working fine :)

[Batambatam]

Thanks a lot for this report, have some homework for this evening 😺

[pfeerick]

I've retracted one issue, so it's a bit less now ;)

[Batambatam]

Hi, I've just pushed some corrections on YAML generation as per the recommendations (tested with jumper TPro radio).
@pfeerick there were an inversion with the active/inactive state, this confirms what you noticed first.

I also noted that radio does not display function switches the same way through model setup, inputs/mixes and logical/custom screens. Function switches names are only displayed on model setup screen. Other screens mix "SW1" to "SW6" for sources and "SE" to "SJ" for switches.

I am not comfortable with that part yet as the firmware handles function switches sometimes like normal switches and sometimes like function switches so I left it as is for now.

[pfeerick]

Yeah, there are some oddites on the TPro function switches stuff still, i.e. #1488 ... so it will be a work in progress.

[pfeerick]

Much better! :) And I think I finally have a handle on what was bugging me before... it seems like functionSwitchLogicalState isn't being populated correctly? So basically, this config:

does not light up 1, 3 and 5 when that model is switched to (but curiously, it is if it is the active model and the radio is turned on).

i.e. this is what companion is writing

functionSwitchConfig: 2730
functionSwitchGroup: 1365
functionSwitchStartConfig: 1092
functionSwitchLogicalState: 0
switchNames:
  0:
    val: SL
  1:
    val: HOR
  2:
    val: AIR
  5:
    val: BEP

after changing a setting (i.e. I just changed a character in the model name so the firmware updated the file), this is what the radio changes it to the following, and now it correctly lights up when switching models.

functionSwitchConfig: 2730
functionSwitchGroup: 1365
functionSwitchStartConfig: 1092
functionSwitchLogicalState: 21
switchNames: 
   0:
      val: "SL"
   1:
      val: "HOR"
   2:
      val: "AIR"
   5:
      val: "BEP"

[pfeerick]

I'm not going to hold it against this PR though, as I don't think it's completely it's fault, there is something rather strange going on with function switches generally, so it could also be something on the radio side still.

[elecpower]

Suggest you check the code from these has been ported:
opentx/opentx#8845
opentx/opentx#8837
opentx/opentx#8834
opentx/opentx#8832

[pfeerick]

Thanks for those Neil.

opentx/opentx#8832 and opentx/opentx#8834 were both imported via #1479, even though the first PR was effectively overwritten by the second. It also pulled in opentx/opentx#8837

opentx/opentx#8845 should be pulled in shortly via #1705

So still on the hunt 🕵️🐛

[Batambatam]

Much better! :) And I think I finally have a handle on what was bugging me before... it seems like functionSwitchLogicalState isn't being populated correctly? So basically, this config:

does not light up 1, 3 and 5 when that model is switched to (but curiously, it is if it is the active model and the radio is turned on).

i.e. this is what companion is writing

functionSwitchConfig: 2730
functionSwitchGroup: 1365
functionSwitchStartConfig: 1092
functionSwitchLogicalState: 0
switchNames:
  0:
    val: SL
  1:
    val: HOR
  2:
    val: AIR
  5:
    val: BEP

I checked on main branch and companion was already writing functionSwitchLogicalState: 0
By the way, I tested with a different config where it starts with 1 lit up and all 5 switches in the same group. When switching models back and forth, 1 turns off and stays.
As soon as I press any function switch from the group it seems to get back to a normal behavior when switching models.

[pfeerick]

Yes, I'll have to read through and try to decode what JC is up to with the function switches to see what that setting is actually for, as it seems to change on the radio... Regardless, I think the current issues arrise from the firmware, not companion, so in this goes... merge conflicts in other PRs (I'm assuming)... here we go! 😆