Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tpro - functions switches playing havoc with autosource #1488

Closed
pfeerick opened this issue Jan 23, 2022 · 2 comments · Fixed by #2505
Closed

tpro - functions switches playing havoc with autosource #1488

pfeerick opened this issue Jan 23, 2022 · 2 comments · Fixed by #2505
Labels
bug 🪲 Something isn't working
Milestone
2.8

Comments

@pfeerick
Copy link
Member

When testing #1479 I encounted this, but also repo'ed this in a nightly build for the TPro - but not in the OTX build so something probably went wrong in the initial import of TPro support.

Basically, autosource is locking on with active function switch - i.e. go to inputs, mixes, source, move something - everything works cool. Now press one of the function switches (assuming left at default 2POS mode), it will get picked as the source (ok), but stays active in as far as it keeps jumping back to the FS when you move any other switches or controls.
@pfeerick pfeerick added this to the 2.6.1 milestone Jan 23, 2022
@pfeerick pfeerick added the bug 🪲 Something isn't working label Jan 23, 2022
@pfeerick pfeerick mentioned this issue Feb 7, 2022
Closed
@pfeerick pfeerick modified the milestones: 2.6.1, 2.8 Mar 16, 2022
@pfeerick pfeerick mentioned this issue Mar 18, 2022
Merged
@raphaelcoeffic
Copy link
Member

@pfeerick is this issue still up-to-date? it seems to me it has been fixed in a PR which did not close the issue, right?

@pfeerick
Copy link
Member Author

pfeerick commented Oct 9, 2022

I haven't checked it recently, but I'm pretty sure it is still present... just haven't had enough motivation to try and whack it...

raphaelcoeffic added a commit that referenced this issue Oct 10, 2022
@raphaelcoeffic
fix(tpro): auto-switch for function switches
cda53c8 
Fixes #1488
@raphaelcoeffic raphaelcoeffic mentioned this issue Oct 10, 2022
Merged
pfeerick pushed a commit that referenced this issue Oct 12, 2022
@raphaelcoeffic
fix(tpro): function switches auto-switch & position matching (#2505)
e7969e7 
* fix(tpro): auto-switch for function switches

Fixes #1488

* fix(tpro): matching function switch UP position
pfeerick pushed a commit that referenced this issue Oct 12, 2022
@raphaelcoeffic @pfeerick
fix(tpro): function switches auto-switch & position matching (#2505)
364c88c 
* fix(tpro): auto-switch for function switches

Fixes #1488

* fix(tpro): matching function switch UP position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🪲 Something isn't working
Projects
None yet
Milestone
2.8
Development

Successfully merging a pull request may close this issue.

fix(tpro): function switches auto-switch & position matching EdgeTX/edgetx
2 participants
@raphaelcoeffic @pfeerick