fix(tpro): function switches auto-switch & position matching #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is still some minor issue here (will follow up separately), but this does fix the issue as documented. As well as fixing a secondary FS led flickering when shutting down which I had suspected was somehow also related. |
|
Nice, testing ok here |
|
Can you try this for me then... setup a group of three FS switches... leave them 2POS, and then try to set the first one as a mix source using autosource detection... mine will only pick up the second and third buttons of the group, and I seem to be able to catch a flash of something else on the screen when it picks up the second. I did name them if that matters. The remaining three buttons are also in different groups just to mix things up. |
pfeerick
pushed a commit
that referenced
this pull request
Oct 12, 2022
* fix(tpro): auto-switch for function switches Fixes #1488 * fix(tpro): matching function switch UP position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1488
Summary of changes: