Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color): prevent event bubbling in Page and TabsGroup #2642

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

raphaelcoeffic
Copy link
Member

... otherwise unexpected things happen.

Fixes #2595

... otherwise unexpected things happen
@raphaelcoeffic raphaelcoeffic added this to the 2.8 milestone Oct 29, 2022
@eshifri
Copy link
Contributor

eshifri commented Oct 29, 2022

Does it fix #2648 as well?

@raphaelcoeffic
Copy link
Member Author

Does it fix #2648 as well?

That can very well be this way. Using page up/page down would switch the tab bellow. When you then exit the present page, the focus is given back to something that does not exist anymore. This is what crashes here, and probably there as well.

@raphaelcoeffic raphaelcoeffic linked an issue Oct 29, 2022 that may be closed by this pull request
1 task
@pfeerick
Copy link
Member

Right, this does indeed fix #2648, and mostly #2595. However, I think the event isn't been cleared, just ignored?

I did this on the transmitter (and can now repo on simu - I couldn't at first then realised the RTN hardkey was important in triggering this latest quirk):

Model Settings -> Mixes (for example) -> Edit -> PGUP (nothing) -> PGDN (nothing) ->RTN (exit) -> Edit mix again -> PGUP (triggers a double rtn back to main view 😮).

@raphaelcoeffic
Copy link
Member Author

@pfeerick the thing you are pointing out is totally independent of the present PR and the original issue. You can find it here #2658 with some explainations.

@pfeerick
Copy link
Member

lol... fair enough... just hadn't noticed it before now (or at least I think I haven't - there was one or two times I thought I had stuck keys, so that could have been it then). I'm easily pleased :)

@pfeerick pfeerick merged commit 40caa99 into main Oct 31, 2022
@pfeerick pfeerick deleted the fix-2595 branch October 31, 2022 07:46
@pfeerick pfeerick mentioned this pull request Oct 31, 2022
1 task
pfeerick pushed a commit that referenced this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.8 RC3 Curves issue EM in setup menu
3 participants